r61560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61559‎ | r61560 | r61561 >
Date:06:56, 27 January 2010
Author:werdna
Status:ok (Comments)
Tags:
Comment:
Revert r60857 changes to LiquidThreads. PLEASE DO NOT RUN BLIND SEARCH AND REPLACES ACROSS MY CODE WITHOUT TESTING THE RESULT.
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.js
——@@ -1542,7 +1542,8 @@
15431543 }
15441544 }
15451545
1546 -mw.ready( function() {
 1546+mw.addOnloadHook( function() {
 1547+ console.profile('Setup');
15471548 // One-time setup for the full page
15481549
15491550 // Update the new thread link
——@@ -1596,5 +1597,6 @@
15971598 $j('#wpSave').live( 'click', liquidThreads.handleAJAXSave );
15981599 $j('#wpTextbox1').live( 'keyup', liquidThreads.onTextboxKeyUp );
15991600 $j(document).click( liquidThreads.handleDocumentClick );
 1601+ console.profileEnd();
16001602 } );
16011603

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60857* renamed mw.addOnloadHook to mw.ready...dale22:46, 8 January 2010

Comments

#Comment by Mdale (talk | contribs)   17:01, 27 January 2010

mw.addOnloadHook was renamed to mw.ready at the request of a different developer. The core was updated in the commit, but it now appears Tim has removed "mw.addOnloadHook" as well.

Status & tagging log