r61519 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61518‎ | r61519 | r61520 >
Date:16:16, 26 January 2010
Author:platonides
Status:reverted
Tags:
Comment:
Parser documentation:
"We are not counting sequences of five apostrophes." comment is wrong.
It was added on r4578, when they stopped being counted, but since r4747 (fixing bug 40) they are counted again.

Clarify what $first variables are.
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
——@@ -1142,7 +1142,6 @@
11431143 $arr[$i] = "''''''";
11441144 }
11451145 # Count the number of occurrences of bold and italics mark-ups.
1146 - # We are not counting sequences of five apostrophes.
11471146 if ( strlen( $arr[$i] ) == 2 ) { $numitalics++; }
11481147 elseif ( strlen( $arr[$i] ) == 3 ) { $numbold++; }
11491148 elseif ( strlen( $arr[$i] ) == 5 ) { $numitalics++; $numbold++; }
——@@ -1160,7 +1159,8 @@
11611160 $i = 0;
11621161
11631162 # These are indexes to the /next/ array entry than the
1164 - # one holding the text matching the condition.
 1163+ # one holding the text matching the condition which gives name
 1164+ # to the variable.
11651165 $firstsingleletterword = -1;
11661166 $firstmultiletterword = -1;
11671167 $firstspace = -1;

Follow-up revisions

RevisionCommit summaryAuthorDate
r61551Revert r61528, r61527, r61526, r61525, r61519, r61515, r61053, r61052 (Parser...tstarling02:41, 27 January 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r4578Bugfix: produce valid XHTML even if user entered invalid '' / ''' mark-up.timwi12:37, 7 August 2004
r4747Fixes to the bold/italics rendering problems [Bug 40]...timwi08:32, 14 August 2004

Status & tagging log