r61489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61488‎ | r61489 | r61490 >
Date:13:57, 25 January 2010
Author:demon
Status:ok
Tags:
Comment:
Fixme on r57980: Memcached would be bad here, rename variable with wg prefix. Fixes to UsabilityInitiative will follow
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2271,9 +2271,7 @@
22722272 */
22732273 function wfUrlProtocols() {
22742274 global $wgUrlProtocols;
2275 -
2276 - // This function is called a lot, cache its return value
2277 - // TODO: Cache this in memcached instead?
 2275+
22782276 static $retval = null;
22792277 if ( !is_null( $retval ) )
22802278 return $retval;
@@ -2289,7 +2287,6 @@
22902288 } else {
22912289 $retval = $wgUrlProtocols;
22922290 }
2293 -
22942291 return $retval;
22952292 }
22962293
Index: trunk/phase3/includes/Skin.php
@@ -378,7 +378,7 @@
379379 $vars = array(
380380 'skin' => $skinName,
381381 'stylepath' => $wgStylePath,
382 - 'urlprotocols' => wfUrlProtocols(),
 382+ 'wgUrlProtocols' => wfUrlProtocols(),
383383 'wgArticlePath' => $wgArticlePath,
384384 'wgScriptPath' => $wgScriptPath,
385385 'wgScriptExtension' => $wgScriptExtension,

Follow-up revisions

RevisionCommit summaryAuthorDate
r61490Followup r61489, rename variable with wg prefixdemon13:59, 25 January 2010
r61608wmf-deployment: Merge (parts of) r59780, r61431, r61489, r61557, r61558, r615...catrope21:59, 27 January 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57980* Export the return value of wfUrlProtocols() to JS for use in the EditToolba...catrope17:35, 21 October 2009

Status & tagging log