r61441 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61440‎ | r61441 | r61442 >
Date:22:43, 23 January 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup to r61436

-rakkaus:#mediawiki-i18n- [23-Jan-2010 22:40:23] PHP Notice: Undefined property: ApiQueryAllpages::$params in /www/w/includes/api/ApiQueryAllpages.php on line 62
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllpages.php
@@ -59,9 +59,9 @@
6060 // Page filters
6161 $this->addTables( 'page' );
6262
63 - if ( $this->params['filterredir'] == 'redirects' )
 63+ if ( $this->params['filterredir'] === 'redirects' )
6464 $this->addWhereFld( 'page_is_redirect', 1 );
65 - else if ( $this->params['filterredir'] == 'nonredirects' )
 65+ else if ( $this->params['filterredir'] === 'nonredirects' )
6666 $this->addWhereFld( 'page_is_redirect', 0 );
6767
6868 $this->addWhereFld( 'page_namespace', $params['namespace'] );
@@ -81,6 +81,7 @@
8282 } else {
8383 $selectFields = $resultPageSet->getPageTableFields();
8484 }
 85+
8586 $this->addFields( $selectFields );
8687 $forceNameTitleIndex = true;
8788 if ( isset ( $params['minsize'] ) ) {
@@ -134,6 +135,7 @@
135136 $this->addOption( 'GROUP BY', implode( ', ', $selectFields ) );
136137 $forceNameTitleIndex = false;
137138 }
 139+
138140 if ( $forceNameTitleIndex )
139141 $this->addOption( 'USE INDEX', 'name_title' );
140142

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61436Normalise check for filterredir in Allpages to that of backlinks...reedy21:28, 23 January 2010

Comments

#Comment by Catrope (talk | contribs)   00:09, 24 January 2010

Fixed in r61445.

Status & tagging log