r61412 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61411‎ | r61412 | r61413 >
Date:12:37, 23 January 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 22240) - API: include time in siteinfo

Patch by Matthew Britton
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQuerySiteinfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuerySiteinfo.php
@@ -154,6 +154,7 @@
155155 $data['variantarticlepath'] = $GLOBALS['wgVariantArticlePath'];
156156 $data['server'] = $GLOBALS['wgServer'];
157157 $data['wikiid'] = wfWikiID();
 158+ $data['time'] = wfTimestamp( TS_ISO_8601, time() );
158159
159160 return $this->getResult()->addValue( 'query', $property, $data );
160161 }
Index: trunk/phase3/RELEASE-NOTES
@@ -799,6 +799,7 @@
800800 descriptionurl
801801 * (bug 20233) ApiLogin::execute() doesn't handle LoginForm :: RESET_PASS
802802 * (bug 22061) API: add prop=headitems to action=parse
 803+* (bug 22240) - API: include time in siteinfo
803804
804805 === Languages updated in 1.16 ===
805806

Follow-up revisions

RevisionCommit summaryAuthorDate
r61414Followup to r61412: don't use time(), we have our own function for thiscatrope15:05, 23 January 2010

Comments

#Comment by Bryan (talk | contribs)   16:59, 24 January 2010

wfTimestamp docs:

 * @param $ts Mixed: the timestamp to convert or 0 for the current timestamp

wfTimestamp( TS_ISO_8601 ) will suffice

Status & tagging log