r61356 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61355‎ | r61356 | r61357 >
Date:04:55, 22 January 2010
Author:mah
Status:reverted (Comments)
Tags:
Comment:
follow up r61352 forgot to add the new global.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -3698,6 +3698,14 @@
36993699 $wgAllowSpecialInclusion = true;
37003700
37013701 /**
 3702+ * 'curl' to use curl or 'php' to use pure php (for which
 3703+ * allow_url_fopen needs to be enabled). If left as false,
 3704+ * HttpFunctions will attempt to use curl if it is available. The use
 3705+ * of curl is strongly encouraged.
 3706+ */
 3707+$wgHTTPEngine = false;
 3708+
 3709+/**
37023710 * Timeout for HTTP requests done internally
37033711 */
37043712 $wgHTTPTimeout = 25;

Follow-up revisions

RevisionCommit summaryAuthorDate
r61408follow up r61356 -- remove globalmah06:23, 23 January 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61352follow up r61078, fixes bug 22224...mah02:17, 22 January 2010

Comments

#Comment by 😂 (talk | contribs)   10:14, 22 January 2010

Why does this need a global? Why can't we just stick to the current style of "use curl if you have it and fopen calls if you don't?"

#Comment by Platonides (talk | contribs)   12:38, 26 January 2010

Was reverted on r61408

Status & tagging log