r61341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61340‎ | r61341 | r61342 >
Date:21:33, 21 January 2010
Author:aaron
Status:ok (Comments)
Tags:
Comment:
* Assorted language tweaks
* Set a few messages back from r61337 that ok to use 'stable'
Modified paths:
  • /trunk/extensions/FlaggedRevs/language/FlaggedRevs.alias.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/OldReviewedPages.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/ReviewedVersions.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/StablePages.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/UnstablePages.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/language/UnstablePages.i18n.php
@@ -8,7 +8,7 @@
99 $messages = array();
1010
1111 $messages['en'] = array(
12 - 'unstablepages' => 'Unpublished pages',
 12+ 'unstablepages' => 'Unstable pages',
1313 'unstablepages-stable' => 'published version',
1414 'unstablepages-text' => 'Below is a list of pages manually configured to show the draft version as the default page content for viewers.',
1515 'unstablepages-none' => 'There are no pages in this list',
Index: trunk/extensions/FlaggedRevs/language/FlaggedRevs.alias.php
@@ -18,7 +18,7 @@
1919 'RevisionReview' => array( 'RevisionReview' ),
2020 'Stabilization' => array( 'Stabilization', 'Stabilisation' ),
2121 'StablePages' => array( 'PublishedPages', 'StablePages' ),
22 - 'ReviewedVersions' => array( 'ReviewedVersions', 'PublishedVersions', 'StableVersions' ),
 22+ 'ReviewedVersions' => array( 'ReviewedVersions', 'StableVersions' /*old name*/ ),
2323 'UnreviewedPages' => array( 'UnreviewedPages' ),
2424 'UnstablePages' => array( 'UnstablePages' ),
2525 'ValidationStatistics' => array( 'ValidationStatistics' ),
Index: trunk/extensions/FlaggedRevs/language/ReviewedVersions.i18n.php
@@ -32,7 +32,7 @@
3333 Parameter $1 is a page title,
3434 Parameter $2 is the count of revisions following, to be used with PLURAL.',
3535 'reviewedversions-review' => '{{Flagged Revs}}
36 -This message is used in the list of published versions of a page (Special:ReviewedVersions) to specify who has reviewed each version.
 36+This message is used in the list of reviewed versions of a page (Special:ReviewedVersions) to specify who has reviewed each version.
3737 * $1 is the date and time of the review
3838 * $2 is the username of the reviewing user, followed by a series of links
3939 * $3 is the date of the review (optional)
Index: trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php
@@ -137,7 +137,7 @@
138138 New [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur&diffonly=0}} changes] may have been made.',
139139 'revreview-quality-same' => 'This is the [[{{MediaWiki:Validationpage}}|published version]], [{{fullurl:{{#Special:Log}}|type=review&page={{FULLPAGENAMEE}}}} approved] on <i>$2</i>.',
140140 'revreview-quality-source' => 'A [{{fullurl:{{FULLPAGENAMEE}}|stableid=$1}} quality version] of this page, [{{fullurl:{{#Special:Log}}|type=review&page={{FULLPAGENAMEE}}}} approved] on <i>$2</i>, was based off this revision.',
141 - 'revreview-quality-title' => 'This is a quality page',
 141+ 'revreview-quality-title' => 'This is a quality version of this page',
142142 'revreview-quick-basic' => '\'\'\'[[{{MediaWiki:Validationpage}}|Checked page]]\'\'\' [[{{fullurl:{{FULLPAGENAMEE}}|stable=0}} view draft]]',
143143 'revreview-quick-basic-old' => '\'\'\'[[{{MediaWiki:Validationpage}}|Checked page]]\'\'\' [[{{fullurl:{{FULLPAGENAMEE}}|stable=0}} view draft]]',
144144 'revreview-quick-basic-same' => '\'\'\'[[{{MediaWiki:Validationpage}}|Checked page]]\'\'\'',
@@ -153,7 +153,7 @@
154154 'revreview-selected' => 'Selected revision of \'\'\'$1:\'\'\'',
155155 'revreview-source' => 'Draft source',
156156 'revreview-stable' => 'Published page',
157 - 'revreview-basic-title' => 'This is a checked page',
 157+ 'revreview-basic-title' => 'This is a checked version of this page',
158158 'revreview-stable1' => 'You may want to view [{{fullurl:$1|stableid=$2}} this flagged version] and see if it is now the [{{fullurl:$1|stable=1}} published version] of this page.',
159159 'revreview-stable2' => 'You may want to view the [{{fullurl:$1|stable=1}} published version] of this page (if there still is one).',
160160 'revreview-style' => 'Readability',
@@ -166,7 +166,7 @@
167167 'revreview-submit-review' => 'Mark reviewed',
168168 'revreview-submit-unreview' => 'Mark unreviewed',
169169 'revreview-submitting' => 'Submitting...',
170 - 'revreview-successful' => '\'\'\'Revision of [[:$1|$1]] successfully flagged. ([{{fullurl:{{#Special:ReviewedVersions}}|page=$2}} view published versions])\'\'\'',
 170+ 'revreview-successful' => '\'\'\'Revision of [[:$1|$1]] successfully flagged. ([{{fullurl:{{#Special:ReviewedVersions}}|page=$2}} view reviewed versions])\'\'\'',
171171 'revreview-successful2' => '\'\'\'Revision of [[:$1|$1]] successfully unflagged.\'\'\'',
172172 'revreview-text' => '\'\'[[{{MediaWiki:Validationpage}}|Published versions]] are the default page content for viewers rather than the newest revision.\'\'',
173173 'revreview-text2' => '\'\'[[{{MediaWiki:Validationpage}}|Published versions]] are checked revisions of pages and can be set as the default content for viewers.\'\'',
@@ -199,10 +199,10 @@
200200 'stable-logentry2' => 'reset published versioning for [[$1]]',
201201 'stable-logpage' => 'Stability log',
202202 'stable-logpagetext' => 'This is a log of changes to the [[{{MediaWiki:Validationpage}}|published version]] configuration of content pages.
203 - A list of stabilized pages can be found at the [[Special:StablePages|published pages list]].',
 203+ The list of pages that require edit approval can be found at the [[Special:StablePages|stable pages list]].',
204204
205205 'revreview-filter-all' => 'all',
206 - 'revreview-filter-stable' => 'Published',
 206+ 'revreview-filter-stable' => 'published',
207207 'revreview-filter-approved' => 'Approved',
208208 'revreview-filter-reapproved' => 'Re-approved',
209209 'revreview-filter-unapproved' => 'Unapproved',
Index: trunk/extensions/FlaggedRevs/language/OldReviewedPages.i18n.php
@@ -9,15 +9,15 @@
1010
1111 $messages['en'] = array(
1212 'oldreviewedpages' => 'Outdated reviewed pages',
13 - 'oldreviewedpages-legend' => 'List reviewed pages with revisions pending review',
 13+ 'oldreviewedpages-legend' => 'List reviewed pages with pending edits',
1414 'oldreviewedpages-list' => 'This page lists {{PLURAL:$1|a reviewed page|reviewed pages}} having pending edits.',
1515 'oldreviewedpages-none' => 'There are currently no pages meeting these criteria',
1616 'oldreviewedpages-hours' => '($1 {{PLURAL:$1|hour|hours}})',
1717 'oldreviewedpages-days' => '($1 {{PLURAL:$1|day|days}})',
1818 'oldreviewedpages-recent' => '(less than 1 hour)',
1919 'oldreviewed-category' => 'Category:',
20 - 'oldreviewed-watched' => 'On my watchlist',
21 - 'oldreviewed-stable' => 'Published',
 20+ 'oldreviewed-watched' => 'Pages on my watchlist',
 21+ 'oldreviewed-stable' => 'Stabilized pages',
2222 'oldreviewed-diff' => 'review',
2323 'oldreviewed-size' => 'Max change (bytes):',
2424 'oldreviewedpages-unwatched' => '(unwatched)',
Index: trunk/extensions/FlaggedRevs/language/StablePages.i18n.php
@@ -8,7 +8,7 @@
99 $messages = array();
1010
1111 $messages['en'] = array(
12 - 'stablepages' => 'Published pages',
 12+ 'stablepages' => 'Stable pages',
1313 'stablepages-stable' => 'published version',
1414 'stablepages-text' => 'Below is a list of pages manually configured to show the published version as the default page content for readers.',
1515 'stablepages-none' => 'There are no pages in this list',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61337More "stable" -> "published"siebrand18:33, 21 January 2010

Comments

#Comment by Siebrand (talk | contribs)   22:01, 21 January 2010

Terminology is getting really confusing, Aaron.

#Comment by Aaron Schulz (talk | contribs)   22:54, 21 January 2010

Probably b/c it's in some transition. I'm trying to avoid using 'stable' unless talking about the configuration of a page (how the published version is found and used).

I also don't want to use 'published' for just any reviewed revision, but rather the latest reviewed one. The one that can be used to show by default. Each page has only one 'published' version if any.

The language needs to be more consistent than it was, rather than using the same words to describe different things.

Status & tagging log