r61253 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61252‎ | r61253 | r61254 >
Date:15:32, 19 January 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Revert r61251 as r61252 fixes the extension (so thats presumably "Wrong")
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -3341,7 +3341,7 @@
33423342 throw new MWException( "Tag hook for $name is not callable\n" );
33433343 }
33443344 $output = call_user_func_array( $this->mTagHooks[$name],
3345 - array( $content, $attributes, &$this, $frame ) );
 3345+ array( $content, $attributes, $this, $frame ) );
33463346 } elseif( isset( $this->mFunctionTagHooks[$name] ) ) {
33473347 list( $callback, $flags ) = $this->mFunctionTagHooks[$name];
33483348 if( !is_callable( $callback ) )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61251cleanup to mwsuggest.js & fix some things suggested by JSLintashley15:29, 19 January 2010
r61252Fixed wrong call function dplTag()...grondin15:30, 19 January 2010

Comments

#Comment by Reedy (talk | contribs)   15:40, 19 January 2010

Of course, I reverted 61249, not 61251

Status & tagging log