r61182 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61181‎ | r61182 | r61183 >
Date:23:36, 17 January 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
UsabilityInitiative: (bug 2124) Fix for r61137: use <1.17 instead of >1.17 in version check.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -264,7 +264,7 @@
265265
266266 // Transforms messages into javascript object members
267267 // ( only not handled automatically )
268 - if ( version_compare( $wgVersion, '1.17', '>') ) {
 268+ if ( version_compare( $wgVersion, '1.17', '<') ) {
269269 foreach ( self::$messages as $i => $message ) {
270270 $escapedMessageValue = Xml::escapeJsString( wfMsg( $message ) );
271271 $escapedMessageKey = Xml::escapeJsString( $message );

Follow-up revisions

RevisionCommit summaryAuthorDate
r61566Reverted the UsabilityInitiative part of r61137 and associated changes in r61......tstarling07:56, 27 January 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61137* added inline section edit to wikiEditor ( using js2 / mwEmbed conventions )...dale17:42, 16 January 2010

Comments

#Comment by Catrope (talk | contribs)   23:52, 17 January 2010

Typo, I meant bug 22124

Status & tagging log