r61180 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61179‎ | r61180 | r61181 >
Date:20:47, 17 January 2010
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Ran stylize.php on DatabaseSqlite
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -21,12 +21,12 @@
2222 * Constructor.
2323 * Parameters $server, $user and $password are not used.
2424 */
25 - function __construct( $server = false, $user = false, $password = false, $dbName = false, $failFunction = false, $flags = 0 ) {
 25+ function __construct( $server = false, $user = false, $password = false, $dbName = false, $failFunction = false, $flags = 0, $fileame = false ) {
2626 global $wgSQLiteDataDir;
2727 $this->mFailFunction = $failFunction;
2828 $this->mFlags = $flags;
2929 $this->mDatabaseFile = self::generateFileName( $wgSQLiteDataDir, $dbName );
30 - if( !is_readable( $this->mDatabaseFile ) )
 30+ if ( !is_readable( $this->mDatabaseFile ) )
3131 throw new DBConnectionError( $this, "SQLite database not accessible" );
3232 $this->mName = $dbName;
3333 $this->open( $server, $user, $password, $dbName );
@@ -136,8 +136,8 @@
137137 $res = null;
138138 }
139139
140 - function fetchObject($res) {
141 - if ($res instanceof ResultWrapper)
 140+ function fetchObject( $res ) {
 141+ if ( $res instanceof ResultWrapper )
142142 $r =& $res->result;
143143 else
144144 $r =& $res;
@@ -155,15 +155,15 @@
156156 return false;
157157 }
158158
159 - function fetchRow($res) {
 159+ function fetchRow( $res ) {
160160 if ( $res instanceof ResultWrapper )
161161 $r =& $res->result;
162162 else
163163 $r =& $res;
164164
165 - $cur = current($r);
166 - if (is_array($cur)) {
167 - next($r);
 165+ $cur = current( $r );
 166+ if ( is_array( $cur ) ) {
 167+ next( $r );
168168 return $cur;
169169 }
170170 return false;

Follow-up revisions

RevisionCommit summaryAuthorDate
r61207rv bit accidentally committed in r61180maxsem17:54, 18 January 2010

Comments

#Comment by 😂 (talk | contribs)   19:10, 19 January 2010

Ok with r61207.

Status & tagging log