r61149 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61148‎ | r61149 | r61150 >
Date:21:03, 16 January 2010
Author:reedy
Status:ok
Tags:
Comment:
(bug 22115) Explode: Subject does not need to be quoted.

Apply supplied patch by Christopher Baker
Modified paths:
  • /trunk/extensions/ParserFunctions/ParserFunctions_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ParserFunctions/ParserFunctions_body.php
——@@ -749,7 +749,6 @@
750750 return $this->tooLongError();
751751 }
752752
753 - $inStr = preg_quote( $inStr, '/' );
754753 $inDiv = preg_quote( $inDiv, '/' );
755754
756755 $matches = preg_split( '/'.$inDiv.'/u', $inStr );
——@@ -766,4 +765,3 @@
767766 return $result;
768767 }
769768 }
770 -

Follow-up revisions

RevisionCommit summaryAuthorDate
r61154Follow up r61149. Using preg_quote on $inReplaceTo replaces too much. However...platonides23:52, 16 January 2010

Status & tagging log