r61130 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61129‎ | r61130 | r61131 >
Date:15:42, 16 January 2010
Author:platonides
Status:resolved (Comments)
Tags:todo 
Comment:
Removed unused code-rev-comment-submit message.
Added an accesskey for the three buttons when viewing a revision.
Set for Save changes the same as for Save page (s), and for Preview for Show Preview (p). 'Save and next unresolved' button get by default an empty accesskey, which is legal.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
——@@ -70,8 +70,8 @@
7171 'code-rev-tag-add' => 'Add tags:',
7272 'code-rev-tag-remove' => 'Remove tags:',
7373 'code-rev-comment-by' => 'Comment by $1',
74 - 'code-rev-comment-submit' => 'Submit comment',
7574 'code-rev-comment-preview' => 'Preview',
 75+ 'code-rev-comment-preview-accesskey' => 'p',
7676 'code-rev-inline-preview' => 'Preview:',
7777 'code-rev-diff' => 'Diff',
7878 'code-rev-diff-link' => 'diff',
——@@ -87,8 +87,9 @@
8888 'code-pathsearch-legend' => 'Search revisions in this repo by path',
8989 'code-pathsearch-path' => 'Path:',
9090 'code-rev-submit' => 'Save changes',
 91+ 'code-rev-submit-accesskey' => 's',
9192 'code-rev-submit-next' => 'Save & next unresolved',
92 -
 93+ 'code-rev-submit-next-accesskey' => '',
9394 'code-batch-status' => 'Change status:',
9495 'code-batch-tags' => 'Change tags:',
9596 'codereview-batch-title' => 'Change all selected revisions',
——@@ -191,11 +192,16 @@
192193 'code-rev-modified-a' => '{{Identical|Added}}',
193194 'code-rev-status' => '{{Identical|Status}}',
194195 'code-rev-tags' => '{{Identical|Tag}}',
195 - 'code-rev-comment-preview' => '{{Identical|Preview}}',
196 - 'code-rev-inline-preview' => '{{Identical|Preview}}',
 196+ 'code-rev-comment-preview' => '{{Identical|Preview}} Caption of the button used to preview a comment.',
 197+ 'code-rev-comment-preview-accesskey' => '{{Identical|accesskey-preview}} Accesskey of the button used to preview a comment. Should be the same as [[MediaWiki:accesskey-preview]]'
 198+ 'code-rev-inline-preview' => '{{Identical|Preview}} Text "Preview" shown before the comment which is currently being previewed.',
197199 'code-status-new' => '{{Identical|New}}',
198200 'code-status-reverted' => '{{Identical|Revert}}',
199201 'code-status-ok' => '{{Identical|OK}}',
 202+ 'code-rev-submit' => 'Caption of the button used to Save changes when viewing a revision.',
 203+ 'code-rev-submit-accesskey' => 'Accesskey of the button used to Save changes when viewing a revision.',
 204+ 'code-rev-submit-next' => 'Caption of the button used when viewing a revision to Save changes moving to next unresolved revision.',
 205+ 'code-rev-submit-next-accesskey' => 'Accesskey of the button used when viewing a revision to Save changes moving to the next unresolved revision.',
200206 'code-pathsearch-path' => '{{Identical|Path}}',
201207 'codereview-batch-submit' => '{{Identical|Submit}}',
202208 'codereview-subtitle' => '{{Identical|For $1}}
——@@ -426,7 +432,6 @@
427433 'code-rev-tag-add' => 'إضافة وسوم:',
428434 'code-rev-tag-remove' => 'أزل الوسوم:',
429435 'code-rev-comment-by' => 'تعليق بواسطة $1',
430 - 'code-rev-comment-submit' => 'إرسال التعليق',
431436 'code-rev-comment-preview' => 'عاين',
432437 'code-rev-inline-preview' => 'معاينة:',
433438 'code-rev-diff' => 'فرق',
——@@ -559,7 +564,6 @@
560565 'code-rev-tag-add' => 'إضافة وسوم:',
561566 'code-rev-tag-remove' => 'أزل الوسوم:',
562567 'code-rev-comment-by' => 'تعليق بواسطة $1',
563 - 'code-rev-comment-submit' => 'إرسال التعليق',
564568 'code-rev-comment-preview' => 'عرض مسبق',
565569 'code-rev-diff' => 'فرق',
566570 'code-rev-diff-link' => 'فرق',
——@@ -719,7 +723,6 @@
720724 'code-rev-tag-add' => 'Дадаць тэгі:',
721725 'code-rev-tag-remove' => 'Выдаліць тэгі:',
722726 'code-rev-comment-by' => 'Камэнтар $1',
723 - 'code-rev-comment-submit' => 'Дадаць камэнтар',
724727 'code-rev-comment-preview' => 'Папярэдні прагляд',
725728 'code-rev-inline-preview' => 'Папярэдні прагляд:',
726729 'code-rev-diff' => 'Зьмена',
——@@ -841,7 +844,6 @@
842845 'code-rev-tag-add' => 'Добавяне на етикети:',
843846 'code-rev-tag-remove' => 'Премахване на етикети:',
844847 'code-rev-comment-by' => 'Коментар от $1',
845 - 'code-rev-comment-submit' => 'Публикуване на коментар',
846848 'code-rev-comment-preview' => 'Предварителен преглед',
847849 'code-rev-inline-preview' => 'Преглед:',
848850 'code-rev-diff' => 'Разлика',
——@@ -970,7 +972,6 @@
971973 'code-rev-tag-add' => 'Ouzhpennañ balizennoù :',
972974 'code-rev-tag-remove' => 'Dilemel balizennoù :',
973975 'code-rev-comment-by' => 'Evezhiadenn gant $1',
974 - 'code-rev-comment-submit' => 'Kinnig an evezhiadenn',
975976 'code-rev-comment-preview' => 'Rakwelet',
976977 'code-rev-inline-preview' => 'Rakwelet :',
977978 'code-rev-diff-link' => 'dif',
——@@ -1107,7 +1108,6 @@
11081109 'code-rev-tag-add' => 'Dodaj oznake:',
11091110 'code-rev-tag-remove' => 'Ukloni oznake:',
11101111 'code-rev-comment-by' => 'Komentar od strane $1',
1111 - 'code-rev-comment-submit' => 'Pošalji komentar',
11121112 'code-rev-comment-preview' => 'Pregled',
11131113 'code-rev-inline-preview' => 'Pregled:',
11141114 'code-rev-diff' => 'Razl',
——@@ -1237,7 +1237,6 @@
12381238 'code-rev-tag-add' => 'Afegeix etiquetes:',
12391239 'code-rev-tag-remove' => 'Elimina etiquetes:',
12401240 'code-rev-comment-by' => 'Comentari de $1',
1241 - 'code-rev-comment-submit' => 'Envia el comentari',
12421241 'code-rev-comment-preview' => 'Previsualitza',
12431242 'code-rev-diff' => 'dif',
12441243 'code-rev-diff-link' => 'dif',
——@@ -1335,7 +1334,6 @@
13361335 'code-rev-tag-add' => 'Přidat značku:',
13371336 'code-rev-tag-remove' => 'Odstranit značky:',
13381337 'code-rev-comment-by' => 'Komentář od $1',
1339 - 'code-rev-comment-submit' => 'Poslat komentář',
13401338 'code-rev-comment-preview' => 'Náhled',
13411339 'code-rev-inline-preview' => 'Náhled:',
13421340 'code-rev-diff' => 'Rozdíl',
——@@ -1574,7 +1572,6 @@
15751573 'code-rev-tag-add' => 'Ergänze Tags:',
15761574 'code-rev-tag-remove' => 'Entferne Tags:',
15771575 'code-rev-comment-by' => 'Kommentar von $1',
1578 - 'code-rev-comment-submit' => 'Kommentar abschicken',
15791576 'code-rev-comment-preview' => 'Vorschau',
15801577 'code-rev-inline-preview' => 'Vorschau:',
15811578 'code-rev-diff' => 'Diff',
——@@ -1716,7 +1713,6 @@
17171714 'code-rev-tag-add' => 'Etiketan de bike:',
17181715 'code-rev-tag-remove' => 'Etiketan wedarne:',
17191716 'code-rev-comment-by' => 'Xulasayê $1î',
1720 - 'code-rev-comment-submit' => 'Xulase qeyd bike',
17211717 'code-rev-comment-preview' => 'Ver qeyd',
17221718 'code-rev-inline-preview' => 'Ver qeyd:',
17231719 'code-rev-diff' => 'Diff',
——@@ -1858,7 +1854,6 @@
18591855 'code-rev-tag-add' => 'Toflicki pśidaś:',
18601856 'code-rev-tag-remove' => 'Toflicki wótwónoźeś:',
18611857 'code-rev-comment-by' => 'Komentar wót $1',
1862 - 'code-rev-comment-submit' => 'Komentar wótpósłaś',
18631858 'code-rev-comment-preview' => 'Pśeglěd',
18641859 'code-rev-inline-preview' => 'Pśeglěd:',
18651860 'code-rev-diff' => 'Rozdźěl',
——@@ -2010,7 +2005,6 @@
20112006 'code-rev-tag-add' => 'Προσθήκη ετικετών:',
20122007 'code-rev-tag-remove' => 'Αφαίρεση ετικετών:',
20132008 'code-rev-comment-by' => 'Σχόλιο από τον $1',
2014 - 'code-rev-comment-submit' => 'Καταχώρηση σχολίου',
20152009 'code-rev-comment-preview' => 'Προεπισκόπιση',
20162010 'code-rev-inline-preview' => 'Προεπισκόπηση:',
20172011 'code-rev-diff' => 'Διαφορά',
——@@ -2148,7 +2142,6 @@
21492143 'code-rev-tag-add' => 'Aldoni etikedojn:',
21502144 'code-rev-tag-remove' => 'Forigi etikedojn:',
21512145 'code-rev-comment-by' => 'Komento de $1',
2152 - 'code-rev-comment-submit' => 'Enmeti komenton',
21532146 'code-rev-comment-preview' => 'Antaŭrigardi',
21542147 'code-rev-inline-preview' => 'Antaŭvido:',
21552148 'code-rev-diff' => 'Diferenco',
——@@ -2294,7 +2287,6 @@
22952288 'code-rev-tag-add' => 'Añadir etiquetas:',
22962289 'code-rev-tag-remove' => 'Quitar etiquetas:',
22972290 'code-rev-comment-by' => 'Comentario de $1',
2298 - 'code-rev-comment-submit' => 'Enviar comentario',
22992291 'code-rev-comment-preview' => 'Previsualización',
23002292 'code-rev-inline-preview' => 'Previsualización:',
23012293 'code-rev-diff' => 'Dif',
——@@ -2511,7 +2503,6 @@
25122504 'code-rev-tag-add' => 'Etiketak gehitu:',
25132505 'code-rev-tag-remove' => 'Etiketak kendu:',
25142506 'code-rev-comment-by' => '$1(e)k komentatuta',
2515 - 'code-rev-comment-submit' => 'Komentarioa bidali',
25162507 'code-rev-comment-preview' => 'Aurreikuspena',
25172508 'code-rev-inline-preview' => 'Aurrikuspena:',
25182509 'code-rev-diff' => 'Ezb',
——@@ -2613,7 +2604,6 @@
26142605 'code-rev-tag-add' => 'افزودن برچسب‌ها:',
26152606 'code-rev-tag-remove' => 'برداشته برچسب‌ها:',
26162607 'code-rev-comment-by' => 'توضیحات توسط $1',
2617 - 'code-rev-comment-submit' => 'ارسال توضیحات',
26182608 'code-rev-comment-preview' => 'پیش‌نمایش',
26192609 'code-rev-diff' => 'تفاوت',
26202610 'code-rev-diff-link' => 'تفاوت',
——@@ -2727,7 +2717,6 @@
27282718 'code-rev-tag-add' => 'Lisää merkintöjä:',
27292719 'code-rev-tag-remove' => 'Poista merkintöjä:',
27302720 'code-rev-comment-by' => 'Käyttäjän $1 kommentti',
2731 - 'code-rev-comment-submit' => 'Lähetä kommentti',
27322721 'code-rev-comment-preview' => 'Esikatselu',
27332722 'code-rev-inline-preview' => 'Esikatselu:',
27342723 'code-rev-diff' => 'Erot',
——@@ -2876,7 +2865,6 @@
28772866 'code-rev-tag-add' => 'Ajouter les balises :',
28782867 'code-rev-tag-remove' => 'Enlever les balises :',
28792868 'code-rev-comment-by' => 'Commentaire par $1',
2880 - 'code-rev-comment-submit' => 'Soumettre le commentaire',
28812869 'code-rev-comment-preview' => 'Prévisualiser',
28822870 'code-rev-inline-preview' => 'Prévisualisation :',
28832871 'code-rev-diff' => 'Différence',
——@@ -3018,7 +3006,6 @@
30193007 'code-rev-tag-add' => 'Apondre les balises :',
30203008 'code-rev-tag-remove' => 'Enlevar les balises :',
30213009 'code-rev-comment-by' => 'Comentèro per $1',
3022 - 'code-rev-comment-submit' => 'Sometre lo comentèro',
30233010 'code-rev-comment-preview' => 'Prèvisualisacion',
30243011 'code-rev-inline-preview' => 'Prèvisualisacion :',
30253012 'code-rev-diff' => 'Dif',
——@@ -3175,7 +3162,6 @@
31763163 'code-rev-tag-add' => 'Engadir as etiquetas:',
31773164 'code-rev-tag-remove' => 'Eliminar as etiquetas:',
31783165 'code-rev-comment-by' => 'Comentario de $1',
3179 - 'code-rev-comment-submit' => 'Enviar o comentario',
31803166 'code-rev-comment-preview' => 'Vista previa',
31813167 'code-rev-inline-preview' => 'Vista previa:',
31823168 'code-rev-diff' => 'Dif',
——@@ -3311,7 +3297,6 @@
33123298 'code-rev-tag-add' => 'Προστιθέναι προσαρτήματα:',
33133299 'code-rev-tag-remove' => 'Ἀφαιρεῖν προσαρτήματα:',
33143300 'code-rev-comment-by' => 'Σχόλιον ὑπὸ τοῦ $1',
3315 - 'code-rev-comment-submit' => 'Ὑποβάλλειν αἴτημα',
33163301 'code-rev-comment-preview' => 'Προθεωρεῖν',
33173302 'code-rev-diff' => 'Διαφ',
33183303 'code-rev-diff-link' => 'διαφ',
——@@ -3421,7 +3406,6 @@
34223407 'code-rev-tag-add' => 'Ergänz Tag:',
34233408 'code-rev-tag-remove' => 'Nimm Tag use:',
34243409 'code-rev-comment-by' => 'Kommentar vu $1',
3425 - 'code-rev-comment-submit' => 'Kommentar abschicke',
34263410 'code-rev-comment-preview' => 'Vorschau',
34273411 'code-rev-inline-preview' => 'Vorschau:',
34283412 'code-rev-diff' => 'Diff',
——@@ -3571,7 +3555,6 @@
35723556 'code-rev-tag-add' => 'הוספת תגיות:',
35733557 'code-rev-tag-remove' => 'הסרת תגיות:',
35743558 'code-rev-comment-by' => 'הערה של $1',
3575 - 'code-rev-comment-submit' => 'שליחת ההערה',
35763559 'code-rev-comment-preview' => 'תצוגה מקדימה',
35773560 'code-rev-inline-preview' => 'תצוגה מקדימה:',
35783561 'code-rev-diff' => 'הבדלים',
——@@ -3716,7 +3699,6 @@
37173700 'code-rev-tag-add' => 'Dodaj oznake:',
37183701 'code-rev-tag-remove' => 'Ukloni oznake:',
37193702 'code-rev-comment-by' => 'Komentirao $1',
3720 - 'code-rev-comment-submit' => 'Postavi komentar',
37213703 'code-rev-comment-preview' => 'Pregled',
37223704 'code-rev-diff' => 'Raz',
37233705 'code-rev-diff-link' => 'raz',
——@@ -3833,7 +3815,6 @@
38343816 'code-rev-tag-add' => 'Taflički přidać:',
38353817 'code-rev-tag-remove' => 'Taflički wotstronić:',
38363818 'code-rev-comment-by' => 'Komentar wot $1',
3837 - 'code-rev-comment-submit' => 'Komentar wotesłać',
38383819 'code-rev-comment-preview' => 'Přehlad',
38393820 'code-rev-inline-preview' => 'Přehlad:',
38403821 'code-rev-diff' => 'Rozdźěl',
——@@ -3976,7 +3957,6 @@
39773958 'code-rev-tag-add' => 'Címkék hozzáadása:',
39783959 'code-rev-tag-remove' => 'Címkék eltávolítása:',
39793960 'code-rev-comment-by' => '$1 hozzászólása',
3980 - 'code-rev-comment-submit' => 'Hozzászólás elküldése',
39813961 'code-rev-comment-preview' => 'Előnézet',
39823962 'code-rev-inline-preview' => 'Előnézet:',
39833963 'code-rev-diff' => 'Diff',
——@@ -4117,7 +4097,6 @@
41184098 'code-rev-tag-add' => 'Adder etiquettas:',
41194099 'code-rev-tag-remove' => 'Remover etiquettas:',
41204100 'code-rev-comment-by' => 'Commento per $1',
4121 - 'code-rev-comment-submit' => 'Submitter commento',
41224101 'code-rev-comment-preview' => 'Previsualisation',
41234102 'code-rev-inline-preview' => 'Previsualisation:',
41244103 'code-rev-diff' => 'Diff',
——@@ -4260,7 +4239,6 @@
42614240 'code-rev-tag-add' => 'Tambah penanda:',
42624241 'code-rev-tag-remove' => 'Hilangkan penanda:',
42634242 'code-rev-comment-by' => 'Komentar oleh $1',
4264 - 'code-rev-comment-submit' => 'Kirim komentar',
42654243 'code-rev-comment-preview' => 'Pratayang',
42664244 'code-rev-inline-preview' => 'Pratayang:',
42674245 'code-rev-diff' => 'Beda',
——@@ -4421,7 +4399,6 @@
44224400 'code-rev-tag-add' => 'Aggiungi tag:',
44234401 'code-rev-tag-remove' => 'Rimuovi tag:',
44244402 'code-rev-comment-by' => 'Commento di $1',
4425 - 'code-rev-comment-submit' => 'Invia commento',
44264403 'code-rev-comment-preview' => 'Anteprima',
44274404 'code-rev-diff' => 'Diff',
44284405 'code-rev-diff-link' => 'diff',
——@@ -4542,7 +4519,6 @@
45434520 'code-rev-tag-add' => 'タグを追加:',
45444521 'code-rev-tag-remove' => 'タグを除去:',
45454522 'code-rev-comment-by' => '$1 によるコメント',
4546 - 'code-rev-comment-submit' => 'コメント送信',
45474523 'code-rev-comment-preview' => 'プレビュー',
45484524 'code-rev-inline-preview' => 'プレビュー:',
45494525 'code-rev-diff' => '差分',
——@@ -4672,7 +4648,6 @@
46734649 'code-rev-tag-add' => "Tambahi tandha (''tag''):",
46744650 'code-rev-tag-remove' => 'Busak tandha',
46754651 'code-rev-comment-by' => 'Komentar déning $1',
4676 - 'code-rev-comment-submit' => 'Kirim komentar',
46774652 'code-rev-comment-preview' => 'Pratayang',
46784653 'code-rev-diff' => 'Diff',
46794654 'code-rev-diff-link' => 'diff',
——@@ -4738,7 +4713,6 @@
47394714 'code-rev-modified-d' => 'წაშლილი',
47404715 'code-rev-status' => 'სტატუსი:',
47414716 'code-rev-comment-by' => '$1-ს კომენტარი',
4742 - 'code-rev-comment-submit' => 'კომენტარის გაგზავნა',
47434717 'code-rev-comment-preview' => 'წინასწარ',
47444718 'code-rev-inline-preview' => 'წინასწარ:',
47454719 'code-rev-diff' => 'განსხ',
——@@ -4901,7 +4875,6 @@
49024876 'code-rev-tag-add' => '태그 추가:',
49034877 'code-rev-tag-remove' => '태그 제거:',
49044878 'code-rev-comment-by' => '$1의 의견',
4905 - 'code-rev-comment-submit' => '의견 제출',
49064879 'code-rev-comment-preview' => '미리 보기',
49074880 'code-rev-diff' => '차이',
49084881 'code-rev-diff-link' => '차이',
——@@ -5029,7 +5002,6 @@
50305003 'code-rev-tag-add' => 'Makeerunge dobei donn:',
50315004 'code-rev-tag-remove' => 'Makeerunge fott nämme:',
50325005 'code-rev-comment-by' => 'Kommentaa vum „$1“',
5033 - 'code-rev-comment-submit' => 'Ene Kommentaa schecke',
50345006 'code-rev-comment-preview' => 'Vör-Aansich',
50355007 'code-rev-inline-preview' => 'Vör-Ansich:',
50365008 'code-rev-diff' => 'Ungerscheid',
——@@ -5169,7 +5141,6 @@
51705142 'code-rev-tag-add' => 'Tagen derbäisetzen:',
51715143 'code-rev-tag-remove' => 'Tagen ewechhuelen:',
51725144 'code-rev-comment-by' => 'Bemierkung vum $1',
5173 - 'code-rev-comment-submit' => 'Bemierkung fortschécken',
51745145 'code-rev-comment-preview' => 'Kucken ouni ze späicheren',
51755146 'code-rev-inline-preview' => 'Kucken ouni ze späicheren:',
51765147 'code-rev-diff' => 'Ënnerscheed',
——@@ -5304,7 +5275,6 @@
53055276 'code-rev-tag-add' => 'Voeg labels toe:',
53065277 'code-rev-tag-remove' => 'Labels wösje:',
53075278 'code-rev-comment-by' => 'Ópmèrking ven $1',
5308 - 'code-rev-comment-submit' => 'Ópmèrking ópslaon',
53095279 'code-rev-comment-preview' => 'Naokieke',
53105280 'code-rev-diff' => 'Vers',
53115281 'code-rev-diff-link' => 'vers',
——@@ -5448,7 +5418,6 @@
54495419 'code-rev-tag-add' => 'Додај ознаки:',
54505420 'code-rev-tag-remove' => 'Избриши ги ознаките:',
54515421 'code-rev-comment-by' => 'Забелешка од $1',
5452 - 'code-rev-comment-submit' => 'Потврди забелешка',
54535422 'code-rev-comment-preview' => 'Преглед',
54545423 'code-rev-inline-preview' => 'Преглед:',
54555424 'code-rev-diff' => 'Разлика',
——@@ -5589,7 +5558,6 @@
55905559 'code-rev-tag-add' => 'റ്റാഗുകൾ ചേർക്കുക:',
55915560 'code-rev-tag-remove' => 'റ്റാഗുകൾ നീക്കം ചെയ്യുക:',
55925561 'code-rev-comment-by' => '$1 ഇട്ട അഭിപ്രായം',
5593 - 'code-rev-comment-submit' => 'അഭിപ്രായം സമർപ്പിക്കുക',
55945562 'code-rev-comment-preview' => 'എങ്ങനെയുണ്ടെന്ന് കാണുക',
55955563 'code-rev-inline-preview' => 'എങ്ങനെയുണ്ടെന്നു കാണുക:',
55965564 'code-rev-diff' => 'വ്യത്യാസം',
——@@ -5724,7 +5692,6 @@
57255693 'code-rev-tag-add' => 'Tambah label:',
57265694 'code-rev-tag-remove' => 'Buang label:',
57275695 'code-rev-comment-by' => 'Ulasan oleh $1',
5728 - 'code-rev-comment-submit' => 'Serah ulasan',
57295696 'code-rev-comment-preview' => 'Pratonton',
57305697 'code-rev-diff' => 'Beza',
57315698 'code-rev-diff-link' => 'beza',
——@@ -5864,7 +5831,6 @@
58655832 'code-rev-tag-add' => 'Tags tofögen:',
58665833 'code-rev-tag-remove' => 'Tags rutnehmen:',
58675834 'code-rev-comment-by' => 'Kommentar vun $1',
5868 - 'code-rev-comment-submit' => 'Kommentar afschicken',
58695835 'code-rev-comment-preview' => 'Vörschau',
58705836 'code-rev-diff' => 'Verscheel',
58715837 'code-rev-diff-link' => 'Verscheel',
——@@ -5993,7 +5959,6 @@
59945960 'code-rev-tag-add' => 'Labels toevoegen:',
59955961 'code-rev-tag-remove' => 'Labels verwijderen:',
59965962 'code-rev-comment-by' => 'Opmerking van $1',
5997 - 'code-rev-comment-submit' => 'Opmerking opslaan',
59985963 'code-rev-comment-preview' => 'Nakijken',
59995964 'code-rev-inline-preview' => 'Voorvertoning:',
60005965 'code-rev-diff' => 'Veranderingen',
——@@ -6134,7 +6099,6 @@
61356100 'code-rev-tag-add' => 'Legg til merke:',
61366101 'code-rev-tag-remove' => 'Fjern merke:',
61376102 'code-rev-comment-by' => 'Kommentar av $1',
6138 - 'code-rev-comment-submit' => 'Legg til kommentar',
61396103 'code-rev-comment-preview' => 'Førehandsvising',
61406104 'code-rev-diff' => 'Skilnad',
61416105 'code-rev-diff-link' => 'skilnad',
——@@ -6263,7 +6227,6 @@
62646228 'code-rev-tag-add' => 'Legg til tagger:',
62656229 'code-rev-tag-remove' => 'Fjern tagger:',
62666230 'code-rev-comment-by' => 'Kommentar av $1',
6267 - 'code-rev-comment-submit' => 'Send inn kommentar',
62686231 'code-rev-comment-preview' => 'Forhåndsvisning',
62696232 'code-rev-inline-preview' => 'Forhåndsvisning:',
62706233 'code-rev-diff' => 'Diff',
——@@ -6405,7 +6368,6 @@
64066369 'code-rev-tag-add' => 'Apondre las balisas :',
64076370 'code-rev-tag-remove' => 'Levar las balisas :',
64086371 'code-rev-comment-by' => 'Comentari per $1',
6409 - 'code-rev-comment-submit' => 'Apondre lo comentari',
64106372 'code-rev-comment-preview' => 'Previsualizacion',
64116373 'code-rev-inline-preview' => 'Previsualizacion :',
64126374 'code-rev-diff' => 'Dif',
——@@ -6581,7 +6543,6 @@
65826544 'code-rev-tag-add' => 'Dodaj znaczniki:',
65836545 'code-rev-tag-remove' => 'Usuń znaczniki:',
65846546 'code-rev-comment-by' => 'Skomentowane przez $1',
6585 - 'code-rev-comment-submit' => 'Dodaj komentarz',
65866547 'code-rev-comment-preview' => 'Podgląd',
65876548 'code-rev-inline-preview' => 'Podgląd:',
65886549 'code-rev-diff' => 'Wykonane zmiany',
——@@ -6757,7 +6718,6 @@
67586719 'code-rev-tag-add' => 'Adicionar etiquetas:',
67596720 'code-rev-tag-remove' => 'Remover etiquetas:',
67606721 'code-rev-comment-by' => 'Comentário de $1',
6761 - 'code-rev-comment-submit' => 'Submeter comentário',
67626722 'code-rev-comment-preview' => 'Antevisão',
67636723 'code-rev-inline-preview' => 'Antevisão:',
67646724 'code-rev-diff' => 'Diferenças',
——@@ -6897,7 +6857,6 @@
68986858 'code-rev-tag-add' => 'Adicionar etiquetas:',
68996859 'code-rev-tag-remove' => 'Remover etiquetas:',
69006860 'code-rev-comment-by' => 'Comentário de $1',
6901 - 'code-rev-comment-submit' => 'Enviar comentário',
69026861 'code-rev-comment-preview' => 'Previsão',
69036862 'code-rev-diff' => 'Diferenças',
69046863 'code-rev-diff-link' => 'dif',
——@@ -7016,7 +6975,6 @@
70176976 'code-rev-tag-add' => 'Adaugă etichete:',
70186977 'code-rev-tag-remove' => 'Elimină etichetele:',
70196978 'code-rev-comment-by' => 'Comentariu de $1',
7020 - 'code-rev-comment-submit' => 'Trimite comentariu',
70216979 'code-rev-comment-preview' => 'Previzualizare',
70226980 'code-rev-inline-preview' => 'Previzualizare:',
70236981 'code-rev-diff' => 'Diferenţă',
——@@ -7090,7 +7048,6 @@
70917049 'code-rev-tag-add' => 'Aggiunge le tag:',
70927050 'code-rev-tag-remove' => 'Scangille le tag:',
70937051 'code-rev-comment-by' => 'Commende de $1',
7094 - 'code-rev-comment-submit' => "Reggistre 'u commende",
70957052 'code-rev-comment-preview' => 'Andeprime',
70967053 'code-rev-inline-preview' => 'Andeprime:',
70977054 'code-rev-diff' => 'Diff',
——@@ -7183,7 +7140,6 @@
71847141 'code-rev-tag-add' => 'Добавить метки:',
71857142 'code-rev-tag-remove' => 'Удалить метки:',
71867143 'code-rev-comment-by' => 'Комментарий от $1',
7187 - 'code-rev-comment-submit' => 'Отправить комментарий',
71887144 'code-rev-comment-preview' => 'Предпросмотр',
71897145 'code-rev-inline-preview' => 'Предпросмотр:',
71907146 'code-rev-diff' => 'Изменение',
——@@ -7325,7 +7281,6 @@
73267282 'code-rev-tag-add' => 'Бэлиэлэри эбии:',
73277283 'code-rev-tag-remove' => 'Бэлиэлэри сотуу:',
73287284 'code-rev-comment-by' => 'Баччатааҕы быһаарыы: $1',
7329 - 'code-rev-comment-submit' => 'Быһаарыыта хааллар (ыыт)',
73307285 'code-rev-comment-preview' => 'Ыытыах иннинэ көрүү',
73317286 'code-rev-inline-preview' => 'Эрдэ көрүү:',
73327287 'code-rev-diff' => 'Уларытыы',
——@@ -7442,7 +7397,6 @@
74437398 'code-rev-tag-add' => 'Junci tag:',
74447399 'code-rev-tag-remove' => 'Leva tag:',
74457400 'code-rev-comment-by' => 'Cummentu di $1',
7446 - 'code-rev-comment-submit' => 'Manna lu cummentu',
74477401 'code-rev-comment-preview' => 'Antiprima',
74487402 'code-rev-diff' => 'Diff',
74497403 'code-rev-diff-link' => 'diff',
——@@ -7558,7 +7512,6 @@
75597513 'code-rev-tag-add' => 'Pridať značky:',
75607514 'code-rev-tag-remove' => 'Odstrániť značky:',
75617515 'code-rev-comment-by' => 'Komentár od $1',
7562 - 'code-rev-comment-submit' => 'Poslať komentár',
75637516 'code-rev-comment-preview' => 'Náhľad',
75647517 'code-rev-inline-preview' => 'Náhľad:',
75657518 'code-rev-diff' => 'Rozdiel',
——@@ -7685,7 +7638,6 @@
76867639 'code-rev-tag-add' => 'Додај тагове:',
76877640 'code-rev-tag-remove' => 'Избриши тагове:',
76887641 'code-rev-comment-by' => 'Комантарисао $1',
7689 - 'code-rev-comment-submit' => 'Пошаљи коментар',
76907642 'code-rev-comment-preview' => 'Прикажи',
76917643 'code-rev-diff' => 'Разл',
76927644 'code-rev-diff-link' => 'разл',
——@@ -7768,7 +7720,6 @@
77697721 'code-rev-tag-add' => 'Dodaj tagove:',
77707722 'code-rev-tag-remove' => 'Izbriši tagove:',
77717723 'code-rev-comment-by' => 'Komantarisao $1',
7772 - 'code-rev-comment-submit' => 'Pošalji komentar',
77737724 'code-rev-comment-preview' => 'Prikaži',
77747725 'code-rev-diff' => 'Razl',
77757726 'code-rev-diff-link' => 'razl',
——@@ -7856,7 +7807,6 @@
78577808 'code-rev-tag-add' => 'Föigje tou Tags:',
78587809 'code-rev-tag-remove' => 'Hoal wäch Tags:',
78597810 'code-rev-comment-by' => 'Kommentoar fon $1',
7860 - 'code-rev-comment-submit' => 'Kommentoar ouseende',
78617811 'code-rev-comment-preview' => 'Foarschau',
78627812 'code-rev-diff' => 'Diff',
78637813 'code-rev-diff-link' => 'Diff',
——@@ -7966,7 +7916,6 @@
79677917 'code-rev-tag-add' => 'Lägg till taggar:',
79687918 'code-rev-tag-remove' => 'Ta bort taggar:',
79697919 'code-rev-comment-by' => 'Kommentar av $1',
7970 - 'code-rev-comment-submit' => 'Skicka kommentar',
79717920 'code-rev-comment-preview' => 'Förhandsgranska',
79727921 'code-rev-inline-preview' => 'Förhandsgranska:',
79737922 'code-rev-diff' => 'Diff',
——@@ -8084,7 +8033,6 @@
80858034 'code-rev-status' => 'స్థితి:',
80868035 'code-rev-status-set' => 'మార్పు స్థితి',
80878036 'code-rev-comment-by' => '$1 యొక్క వ్యాఖ్య',
8088 - 'code-rev-comment-submit' => 'వ్యాఖ్యని దాఖలుచేయి',
80898037 'code-rev-comment-preview' => 'మునుజూపు',
80908038 'code-rev-inline-preview' => 'మునుజూపు:',
80918039 'code-rev-diff' => 'తేడా',
——@@ -8177,7 +8125,6 @@
81788126 'code-rev-tag-add' => 'Изофаи барчасбҳо:',
81798127 'code-rev-tag-remove' => 'Пок кардани барчасбҳо:',
81808128 'code-rev-comment-by' => 'Тавзеҳ аз тарафи $1',
8181 - 'code-rev-comment-submit' => 'Ирсоли тавзеҳ',
81828129 'code-rev-comment-preview' => 'Пешнамоиш',
81838130 'code-rev-diff' => 'Тафовут',
81848131 'code-rev-diff-link' => 'тафовут',
——@@ -8269,7 +8216,6 @@
82708217 'code-rev-tag-add' => 'Izofai barcasbho:',
82718218 'code-rev-tag-remove' => 'Pok kardani barcasbho:',
82728219 'code-rev-comment-by' => 'Tavzeh az tarafi $1',
8273 - 'code-rev-comment-submit' => 'Irsoli tavzeh',
82748220 'code-rev-comment-preview' => 'Peşnamoiş',
82758221 'code-rev-diff' => 'Tafovut',
82768222 'code-rev-diff-link' => 'tafovut',
——@@ -8393,7 +8339,6 @@
83948340 'code-rev-tag-add' => 'Teg goş:',
83958341 'code-rev-tag-remove' => 'Teg aýyr:',
83968342 'code-rev-comment-by' => '$1 tarapyndan teswir',
8397 - 'code-rev-comment-submit' => 'Teswir tabşyr',
83988343 'code-rev-comment-preview' => 'Deslapky syn',
83998344 'code-rev-inline-preview' => 'Deslapky syn:',
84008345 'code-rev-diff' => 'Tapawut',
——@@ -8528,7 +8473,6 @@
85298474 'code-rev-tag-add' => 'Idagdag ang mga tatak:',
85308475 'code-rev-tag-remove' => 'Alisin ang mga tatak:',
85318476 'code-rev-comment-by' => 'Komento ni $1',
8532 - 'code-rev-comment-submit' => 'Ipasa ang komento/puna',
85338477 'code-rev-comment-preview' => 'Unang tingin',
85348478 'code-rev-diff' => 'Pagkakaiba',
85358479 'code-rev-diff-link' => 'pagkakaiba',
——@@ -8655,7 +8599,6 @@
86568600 'code-rev-tag-add' => 'Etiket ekle:',
86578601 'code-rev-tag-remove' => 'Etiket çıkar:',
86588602 'code-rev-comment-by' => '$1 kullanıcısından yorum',
8659 - 'code-rev-comment-submit' => 'Yorumu gönder',
86608603 'code-rev-comment-preview' => 'Önizleme',
86618604 'code-rev-inline-preview' => 'Önizleme:',
86628605 'code-rev-diff' => 'Fark',
——@@ -8816,7 +8759,6 @@
88178760 'code-rev-tag-add' => 'Додати мітки:',
88188761 'code-rev-tag-remove' => 'Вилучити мітки:',
88198762 'code-rev-comment-by' => 'Коментар від $1',
8820 - 'code-rev-comment-submit' => 'Відправити коментар',
88218763 'code-rev-comment-preview' => 'Попередній перегляд',
88228764 'code-rev-inline-preview' => 'Попередній перегляд:',
88238765 'code-rev-diff' => 'Зміна',
——@@ -8958,7 +8900,6 @@
89598901 'code-rev-tag-add' => 'Zonta tag:',
89608902 'code-rev-tag-remove' => 'Cava tag:',
89618903 'code-rev-comment-by' => 'Comento de $1',
8962 - 'code-rev-comment-submit' => 'Invia comento',
89638904 'code-rev-comment-preview' => 'Anteprima',
89648905 'code-rev-inline-preview' => 'Anteprima:',
89658906 'code-rev-diff' => 'Dif',
——@@ -9139,7 +9080,6 @@
91409081 'code-rev-tag-add' => 'Thêm thẻ:',
91419082 'code-rev-tag-remove' => 'Dời thẻ:',
91429083 'code-rev-comment-by' => '$1 ghi chú',
9143 - 'code-rev-comment-submit' => 'Lưu ghi chú',
91449084 'code-rev-comment-preview' => 'Xem trước',
91459085 'code-rev-inline-preview' => 'Xem trước:',
91469086 'code-rev-diff' => 'So sánh',
——@@ -9247,7 +9187,6 @@
92489188 'code-rev-status' => 'Stad:',
92499189 'code-rev-status-set' => 'Votükön stadi',
92509190 'code-rev-comment-by' => 'Küpet gebana: $1',
9251 - 'code-rev-comment-submit' => 'Sedön küpeti',
92529191 'code-rev-comment-preview' => 'Büologed',
92539192 'code-rev-diff' => 'Dif',
92549193 'code-rev-diff-link' => 'dif',
——@@ -9351,7 +9290,6 @@
93529291 'code-rev-tag-add' => '加標籤：',
93539292 'code-rev-tag-remove' => '拎走標籤：',
93549293 'code-rev-comment-by' => '$1嘅註解',
9355 - 'code-rev-comment-submit' => '遞交註解',
93569294 'code-rev-comment-preview' => '預覽',
93579295 'code-rev-diff' => '差異',
93589296 'code-rev-diff-link' => '差異',
——@@ -9488,7 +9426,6 @@
94899427 'code-rev-tag-add' => '添加标签：',
94909428 'code-rev-tag-remove' => '移除标签：',
94919429 'code-rev-comment-by' => '$1 的评论',
9492 - 'code-rev-comment-submit' => '提交评论',
94939430 'code-rev-comment-preview' => '预览',
94949431 'code-rev-inline-preview' => '预览：',
94959432 'code-rev-diff' => '差异',
——@@ -9618,7 +9555,6 @@
96199556 'code-rev-tag-add' => '添加標籤：',
96209557 'code-rev-tag-remove' => '移除標籤：',
96219558 'code-rev-comment-by' => '$1 的評論',
9622 - 'code-rev-comment-submit' => '提交評論',
96239559 'code-rev-comment-preview' => '預覽',
96249560 'code-rev-inline-preview' => '預覽：',
96259561 'code-rev-diff' => '差異',
Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
——@@ -653,11 +653,11 @@
654654
655655 protected function addActionButtons() {
656656 return '<div>' .
657 - Xml::submitButton( wfMsg( 'code-rev-submit' ), array( 'name' => 'wpSave' ) ) .
 657+ Xml::submitButton( wfMsg( 'code-rev-submit' ), array( 'name' => 'wpSave' ), 'accesskey' => wfMsg( 'code-rev-submit-accesskey' ) ) .
658658 ' ' .
659 - Xml::submitButton( wfMsg( 'code-rev-submit-next' ), array( 'name' => 'wpSaveAndNext' ) ) .
 659+ Xml::submitButton( wfMsg( 'code-rev-submit-next' ), array( 'name' => 'wpSaveAndNext' ), 'accesskey' => wfMsg( 'code-rev-submit-next-accesskey' ) ) .
660660 ' ' .
661 - Xml::submitButton( wfMsg( 'code-rev-comment-preview' ), array( 'name' => 'wpPreview' ) ) .
 661+ Xml::submitButton( wfMsg( 'code-rev-comment-preview' ), array( 'name' => 'wpPreview', 'accesskey' => wfMsg( 'code-rev-comment-preview-accesskey' ) ) ) .
662662 '</div>';
663663 }
664664 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r61131Follow-up r61130: Ignore messages for translatewikiraymond15:48, 16 January 2010
r61132Follow-up r61130: Fix syntax errorraymond15:50, 16 January 2010
r61325Fixed fatal syntax errors from r61130aaron07:43, 21 January 2010

Comments

#Comment by Simetrical (talk | contribs)   23:03, 17 January 2010

Maybe you should use Linker::accesskey() here? That allows suppression of the accesskey by setting to '-', and returns false if it shouldn't be there (so the attribute won't be output). You'd have to rename the message to start with "accesskey-", but that kind of thing is already done for other message types, like 'right-renameuser' defined in Renameuser.

#Comment by Platonides (talk | contribs)   17:45, 27 January 2010

Xml::submitButton( 'code-rev-comment-preview' , array( 'name' => 'wpPreview', 'accesskey' => false ) ) still output an empty accesskey attribute.

#Comment by Simetrical (talk | contribs)   19:01, 27 January 2010

So use Html::element() instead.  :) That has all sorts of other benefits too. I've made submitButton() wrap Html::element() instead of Xml::element() in r61587. We could also change the behavior of Xml::expandAttributes() to respect a value of false as "suppress the attribute", but that might break things -- probably some things are relying on false == here (sigh). (Possibly some things were already relying on that for Xml::submitButton(), but we can at least find out gradually . . .)

#Comment by Platonides (talk | contribs)   21:11, 27 January 2010

I don't think that's a good idea, see r61587. expandAttributes seems to only be called at Linker and Xml. There's even a FIXME on Linker::tooltipAndAccesskeyAttribs() begging for that.

#Comment by Simetrical (talk | contribs)   19:20, 28 January 2010

The problem is if someone was calling Xml::element( 'foo', array( 'something' => $bar ) ), and sometimes $bar === false, and this was outputting something="" and that was what they wanted. something="" is not always the same as omitting the something attribute entirely. I wouldn't object to making Xml::expandAttributes() respect false, but anything producing HTML elements should be calling Html methods regardless, not Xml.

#Comment by Platonides (talk | contribs)   21:27, 28 January 2010

Who would be doing so?

That would be quite broken.

Maybe there is some crazy usage in the api, though.

#Comment by Simetrical (talk | contribs)   21:50, 28 January 2010

This kind of thing often happens inadvertently when you use weak typing. See r61342 for a recent real-world example.

Status & tagging log