r61024 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61023‎ | r61024 | r61025 >
Date:21:25, 13 January 2010
Author:ialex
Status:ok
Tags:
Comment:
* Document a bit
* Fix some doxygen warnings
Modified paths:
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)
  • /trunk/phase3/includes/FileRevertForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FileRevertForm.php
@@ -17,7 +17,7 @@
1818 /**
1919 * Constructor
2020 *
21 - * @param File $file File we're reverting
 21+ * @param $file File we're reverting
2222 */
2323 public function __construct( $file ) {
2424 $this->title = $file->getTitle();
Index: trunk/phase3/includes/FileDeleteForm.php
@@ -17,7 +17,7 @@
1818 /**
1919 * Constructor
2020 *
21 - * @param File $file File we're deleting
 21+ * @param $file File object we're deleting
2222 */
2323 public function __construct( $file ) {
2424 $this->title = $file->getTitle();
@@ -90,6 +90,15 @@
9191 $this->showLogEntries();
9292 }
9393
 94+ /**
 95+ * Really delete the file
 96+ *
 97+ * @param $title Title object
 98+ * @param $file File object
 99+ * @param $oldimage String: archive name
 100+ * @param $reason String: reason of the deletion
 101+ * @param $suppress Boolean: whether to mark all deleted versions as restricted
 102+ */
94103 public static function doDelete( &$title, &$file, &$oldimage, $reason, $suppress ) {
95104 global $wgUser;
96105 $article = null;
@@ -226,8 +235,8 @@
227236 * showing an appropriate message depending upon whether
228237 * it's a current file or an old version
229238 *
230 - * @param string $message Message base
231 - * @return string
 239+ * @param $message String: message base
 240+ * @return String
232241 */
233242 private function prepareMessage( $message ) {
234243 global $wgLang;

Status & tagging log