r61023 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61022‎ | r61023 | r61024 >
Date:20:39, 13 January 2010
Author:simetrical
Status:ok
Tags:
Comment:
Don't load nonexistent fix files for non-Monobook

Bug 14717. I just hardcoded "&& skin == 'monobook'" in wikibits.js. As
far as I know, no other skin actually uses fix files -- Vector, for
instance, just uses selector hacks in main-{ltr,rtl}.css as far as I
know. Using separate files is arguably a bad idea, because it
gratuitously adds extra loads, encourages style changes to fall out of
sync, etc. Plus, happily, the era of CSS fixes seems to be drawing to a
close -- Firefox 3.0, IE8, Opera 10, and all Safari and Chrome get by
fine with no fix files for any skin.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
——@@ -101,10 +101,8 @@
102102 return s;
103103 }
104104
105 -// special stylesheet links
106 -if ( typeof stylepath != 'undefined' && typeof skin != 'undefined' ) {
107 - // FIXME: This tries to load the stylesheets even for skins where they
108 - // don't exist, i.e., everything but Monobook.
 105+// Special stylesheet links for Monobook only (see bug 14717)
 106+if ( typeof stylepath != 'undefined' && skin == 'monobook' ) {
109107 if ( opera6_bugs ) {
110108 importStylesheetURI( stylepath + '/' + skin + '/Opera6Fixes.css' );
111109 } else if ( opera7_bugs ) {
Index: trunk/phase3/RELEASE-NOTES
——@@ -700,6 +700,7 @@
701701 * (bug 2658) Don't attempt to set the TZ environment variable.
702702 * (bug 9794) User rights log entries for foreign user now links to the foreign
703703 user's page if possible
 704+* (bug 14717) Don't load nonexistent CSS fix files for non-Monobook skins
704705
705706 == API changes in 1.16 ==
706707

Status & tagging log