r61018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61017‎ | r61018 | r61019 >
Date:19:50, 13 January 2010
Author:siebrand
Status:deferred (Comments)
Tags:
Comment:
Use $wgTranslateGroupRoot
Modified paths:
  • /trunk/extensions/Translate/groups/Wikia/WikiaExtensions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/Wikia/WikiaExtensions.php
@@ -1,16 +1,17 @@
22 <?php
33
4 -
54 class PremadeWikiaExtensionGroups extends PremadeMediawikiExtensionGroups {
65 protected $useConfigure = false;
76 protected $idPrefix = 'wikia-';
87 protected $path = null;
98
109 public function __construct() {
 10+ global $wgTranslateGroupRoot;
 11+
1112 parent::__construct();
1213 $dir = dirname( __FILE__ );
1314 $this->definitionFile = $dir . '/extensions.txt';
14 - $this->path = '/var/www/externals/wikia/';
 15+ $this->path = '$wgTranslateGroupRoot/wikia/';
1516 }
1617
1718 protected function addAllMeta() {

Comments

#Comment by Platonides (talk | contribs)   23:05, 15 January 2010

You sure wanted double quotes?

#Comment by Platonides (talk | contribs)   23:06, 15 January 2010

It was fixed on r61027

Status & tagging log