r60975 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60974‎ | r60975 | r60976 >
Date:18:39, 12 January 2010
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
Fix parsertests by including the globalimagelinks table in tables to be duplicated
Modified paths:
  • /trunk/extensions/GlobalUsage/GlobalUsage.php (modified) (history)
  • /trunk/extensions/GlobalUsage/GlobalUsageHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalUsage/GlobalUsageHooks.php
@@ -99,5 +99,13 @@
100100
101101 return self::$gu;
102102 }
 103+
 104+ /**
 105+ * Hook to make sure globalimagelinks table gets duplicated for parsertests
 106+ */
 107+ public static function onParserTestTables ( &$tables ) {
 108+ $tables[] = 'globalimagelinks';
 109+ return true;
 110+ }
103111
104112 }
\ No newline at end of file
Index: trunk/extensions/GlobalUsage/GlobalUsage.php
@@ -70,8 +70,8 @@
7171 $wgHooks['TitleMoveComplete'][] = 'GlobalUsageHooks::onTitleMoveComplete';
7272 $wgHooks['ImagePageAfterImageLinks'][] = 'SpecialGlobalUsage::onImagePageAfterImageLinks';
7373 $wgHooks['ImagePageShowTOC'][] = 'SpecialGlobalUsage::onImagePageShowTOC';
 74+$wgHooks['ParserTestTables'][] = 'GlobalUsageHooks::onParserTestTables';
7475
75 -
7676 // If set to false, the local database contains the globalimagelinks table
7777 // Else set to something understandable to LBFactory
7878 $wgGlobalUsageDatabase = false;

Comments

#Comment by MarkAHershberger (talk | contribs)   19:02, 12 January 2010

Is this a follow up to r60593? Still fails for me, if so.

#Comment by Bryan (talk | contribs)   19:23, 12 January 2010

Yeah, I know. I needed this to get the parser tests running at all.

Status & tagging log