r60924 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60923‎ | r60924 | r60925 >
Date:06:17, 11 January 2010
Author:mah
Status:ok (Comments)
Tags:
Comment:
Add test for bug where variant was persisting when it shouldn't
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
@@ -6939,6 +6939,18 @@
69406940 !! end
69416941
69426942 !! test
 6943+Adding explicit conversion rule for title (T flag)
 6944+!! options
 6945+language=zh variant=zh showtitle
 6946+!! input
 6947+Should be stripped-{T|zh:China;zh-tw:Taiwan}-!
 6948+!! result
 6949+China
 6950+<p>Should be stripped!
 6951+</p>
 6952+!! end
 6953+
 6954+!! test
69436955 Raw output of variant escape tags (R flag)
69446956 !! options
69456957 language=zh variant=zh-tw
@@ -7514,30 +7526,6 @@
75157527 <a href="https://www.mediawiki.org/wiki/Main_Page#section" title="Main Page">#section</a>
75167528 !! end
75177529
7518 -!! test
7519 -Adding explicit conversion rule for title (T flag)
7520 -!! options
7521 -language=zh variant=zh-tw showtitle **** disabled (for now) because I think it uncovers a bug and I want a reminder
7522 -!! input
7523 -Should be stripped-{T|zh:China;zh-tw:Taiwan}-!
7524 -!! result
7525 -Taiwan
7526 -<p>Should be stripped!
7527 -</p>
7528 -!! end
7529 -
7530 -!! test
7531 -Adding explicit conversion rule for title (T flag)
7532 -!! options
7533 -language=zh variant=zh showtitle **** disabled (for now) because I think it uncovers a bug and I want a reminder
7534 -!! input
7535 -Should be stripped-{T|zh:China;zh-tw:Taiwan}-!
7536 -!! result
7537 -China
7538 -<p>Should be stripped!
7539 -</p>
7540 -!! end
7541 -
75427530 TODO:
75437531 more images
75447532 more tables

Follow-up revisions

RevisionCommit summaryAuthorDate
r60953follow up r60924 Make sure the test has a unique, descriptive name.mah00:14, 12 January 2010

Comments

#Comment by OverlordQ (talk | contribs)   07:11, 11 January 2010

Each test needs a unique name. There's two with: 'Adding explicit conversion rule for title (T flag)'

Status & tagging log