r60876 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60875‎ | r60876 | r60877 >
Date:20:18, 9 January 2010
Author:aaron
Status:ok
Tags:
Comment:
bug 21411 'Add a new message rev-suppressed-no-diff for diff without entry in public log'
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceInterface.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceInterface.php
@@ -377,9 +377,10 @@
378378 $multi = $this->getMultiNotice();
379379 $wgOut->addHTML( $this->addHeader( '', $oldHeader, $newHeader, $multi ) );
380380 if( !$allowed ) {
 381+ $msg = $suppressed ? 'rev-suppressed-no-diff' : 'rev-deleted-no-diff';
381382 # Give explanation for why revision is not visible
382383 $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n",
383 - array( 'rev-deleted-no-diff' ) );
 384+ array( $msg ) );
384385 } else {
385386 # Give explanation and add a link to view the diff...
386387 $link = $this->mTitle->getFullUrl( array(
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1431,29 +1431,30 @@
14321432 'rev-deleted-event' => '(log action removed)',
14331433 'rev-deleted-user-contribs' => '[username or IP address removed - edit hidden from contributions]',
14341434 'rev-deleted-text-permission' => "This page revision has been '''deleted'''.
1435 -There may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
 1435+Details can be found in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
14361436 'rev-deleted-text-unhide' => "This page revision has been '''deleted'''.
1437 -There may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].
 1437+Details can be found in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].
14381438 As an administrator you can still [$1 view this revision] if you wish to proceed.",
14391439 'rev-suppressed-text-unhide' => "This page revision has been '''suppressed'''.
1440 -There may be details in the [{{fullurl:{{#Special:Log}}/suppress|page={{FULLPAGENAMEE}}}} suppression log].
 1440+Details can be found in the [{{fullurl:{{#Special:Log}}/suppress|page={{FULLPAGENAMEE}}}} suppression log].
14411441 As an administrator you can still [$1 view this revision] if you wish to proceed.",
14421442 'rev-deleted-text-view' => "This page revision has been '''deleted'''.
1443 -As an administrator you can view it; there may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
 1443+As an administrator you can view it; details can be found in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
14441444 'rev-suppressed-text-view' => "This page revision has been '''suppressed'''.
1445 -As an administrator you can view it; there may be details in the [{{fullurl:{{#Special:Log}}/suppress|page={{FULLPAGENAMEE}}}} suppression log].",
 1445+As an administrator you can view it; details can be found in the [{{fullurl:{{#Special:Log}}/suppress|page={{FULLPAGENAMEE}}}} suppression log].",
14461446 'rev-deleted-no-diff' => "You cannot view this diff because one of the revisions has been '''deleted'''.
1447 -There may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
 1447+Details can be found in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
 1448+'rev-suppressed-no-diff' => "You cannot view this diff because one of the revisions has been '''deleted'''.",
14481449 'rev-deleted-unhide-diff' => "One of the revisions of this diff has been '''deleted'''.
1449 -There may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].
 1450+Details can be found in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].
14501451 As an administrator you can still [$1 view this diff] if you wish to proceed.",
14511452 'rev-suppressed-unhide-diff' => "One of the revisions of this diff has been '''suppressed'''.
1452 -There may be details in the [{{fullurl:{{#Special:Log}}/suppress|page={{FULLPAGENAMEE}}}} suppression log].
 1453+Details can be found in the [{{fullurl:{{#Special:Log}}/suppress|page={{FULLPAGENAMEE}}}} suppression log].
14531454 As an administrator you can still [$1 view this diff] if you wish to proceed.",
14541455 'rev-deleted-diff-view' => "One of the revisions of this diff has been '''deleted'''.
1455 -As an administrator you can view this diff; there may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
 1456+As an administrator you can view this diff; details can be found in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].",
14561457 'rev-suppressed-diff-view' => "One of the revisions of this diff has been '''suppressed'''.
1457 -As an administrator you can view this diff; there may be details in the [{{fullurl:{{#Special:Log}}/suppress|page={{FULLPAGENAMEE}}}} suppression log].",
 1458+As an administrator you can view this diff; details can be found in the [{{fullurl:{{#Special:Log}}/suppress|page={{FULLPAGENAMEE}}}} suppression log].",
14581459 'rev-delundel' => 'show/hide',
14591460 'rev-showdeleted' => 'show',
14601461 'revisiondelete' => 'Delete/undelete revisions',

Follow-up revisions

RevisionCommit summaryAuthorDate
r60877Update for r60876aaron20:19, 9 January 2010

Status & tagging log