r60833 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r60832‎ | r60833 | r60834 >
Date:08:49, 8 January 2010
Author:mah
Status:resolved (Comments)
Tags:
Comment:
follow up r60829
Gah — really need to get E_STRICT working in my test environment.
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
——@@ -311,7 +311,7 @@
312312 $tpl->set( 'userlangattributes', '');
313313 $tpl->set( 'specialpageattributes', '');
314314
315 - $code = $wgLang->getCode();
 315+ $lang = $wgLang->getCode();
316316 $dir = $wgLang->getDir();
317317 if ( $code !== $wgContLang->getCode() || $dir !== $wgContLang->getDir() ) {
318318 $attrs = "lang='$lang' xml:lang='$lang' dir='$dir'";

Follow-up revisions

RevisionCommit summaryAuthorDate
r60834follow-up 60833...mah08:55, 8 January 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60829Follow up r60798 & r60785...mah03:34, 8 January 2010

Comments

#Comment by Raymond (talk | contribs)   08:51, 8 January 2010

The next one:

PHP Notice: Undefined variable: code in /var/www/w/includes/SkinTemplate.php on line 316

#Comment by MarkAHershberger (talk | contribs)   08:55, 8 January 2010

surely that's all?

#Comment by Krinkle (talk | contribs)   11:55, 21 June 2011

This was fixed in the follow-up r60834.

Status & tagging log