r60791 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60790‎ | r60791 | r60792 >
Date:10:44, 7 January 2010
Author:mkroetzsch
Status:deferred (Comments)
Tags:
Comment:
minor fix
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php
@@ -1790,6 +1790,7 @@
17911791 */
17921792 protected function changeSMWPageID($oldid,$newid,$oldnamespace=-1,$newnamespace=-1, $sdata=true, $podata=true) {
17931793 $fname = 'SMW::changeSMWPageID';
 1794+ $db =& wfGetDB( DB_MASTER );
17941795 // Update bnode references that use namespace field to store ids:
17951796 if ($sdata) { // bnodes are part of the data of a subject
17961797 $db->update('smw_ids', array('smw_namespace' => $newid),

Comments

#Comment by Nikerabbit (talk | contribs)   12:19, 7 January 2010

You shouldn't use =& since the support for PHP4 was dropped. Plain = is enough.

Status & tagging log