r60779 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60778‎ | r60779 | r60780 >
Date:07:41, 7 January 2010
Author:robla
Status:resolved (Comments)
Tags:
Comment:
Adding forgotten patch-img_file_ext.sql. Critical for bug 4421 fix
Modified paths:
  • /branches/extensionless-files/maintenance/archives/patch-img_file_ext.sql (added) (history)

Diff [purge]

Index: branches/extensionless-files/maintenance/archives/patch-img_file_ext.sql
@@ -0,0 +1,20 @@
 2+-- media type columns, added for 1.16
 3+-- this alters the scheme for 1.16, img_type is no longer used.
 4+
 5+ALTER TABLE /*$wgDBprefix*/image ADD (
 6+ -- File extension, appended to the on-disk file in cases where the
 7+ -- extension derived from img_name doesn't match the media type of
 8+ -- the file. See bug #4421.
 9+ img_file_ext varchar(32) binary NOT NULL default ''
 10+);
 11+
 12+ALTER TABLE /*$wgDBprefix*/oldimage ADD (
 13+ -- oldimage table counterpart of img_file_ext
 14+ oi_file_ext varchar(32) binary NOT NULL default ''
 15+);
 16+
 17+ALTER TABLE /*$wgDBprefix*/filearchive ADD (
 18+ -- filearchive table counterpart of img_file_ext
 19+ fa_file_ext varchar(32) binary NOT NULL default ''
 20+);
 21+

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60762Development branch for bug 4421 (Image file extension should not be part of t...robla03:14, 7 January 2010
r60772Adding new functions in preparation for decoupling page title from MIME type ...robla07:13, 7 January 2010
r60773Decouple page titles from MIME type, adding img_file_ext field to db (bug 4421robla07:15, 7 January 2010
r60778Some extra file deletion debug logging (probably superfluous)...robla07:32, 7 January 2010

Comments

#Comment by Siebrand (talk | contribs)   08:59, 7 January 2010

Is missing svn:eol-style native prop.

#Comment by Siebrand (talk | contribs)   09:01, 7 January 2010

That was fixed by in r60783 by robla. Thanks. Just an FYI: if you add a reference to another revision in your commit summary, that commit will turn up on a page like this just below the diff. See for example bottom of r58275.

Status & tagging log