r60714 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r60713‎ | r60714 | r60715 >
Date:05:20, 6 January 2010
Author:yaron
Status:deferred (Comments)
Tags:
Comment:
Default number for 'columns' parameter now varies between formats
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QP_Category.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php
——@@ -192,7 +192,7 @@
193193 }
194194 $params[] = array('name' => 'template', 'type' => 'string', 'description' => wfMsg('smw_paramdesc_template'));
195195 if (! $plainlist) {
196 - $params[] = array('name' => 'columns', 'type' => 'int', 'description' => wfMsg('smw_paramdesc_columns'));
 196+ $params[] = array('name' => 'columns', 'type' => 'int', 'description' => wfMsg('smw_paramdesc_columns', 1));
197197 }
198198 return $params;
199199 }
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QP_Category.php
——@@ -163,7 +163,7 @@
164164 public function getParameters() {
165165 $params = parent::getParameters();
166166 $params = array_merge($params, parent::textDisplayParameters());
167 - $params[] = array('name' => 'columns', 'type' => 'int', 'description' => wfMsg('smw_paramdesc_columns'));
 167+ $params[] = array('name' => 'columns', 'type' => 'int', 'description' => wfMsg('smw_paramdesc_columns', 3));
168168 return $params;
169169 }
170170

Comments

#Comment by Raymond (talk | contribs)   08:46, 6 January 2010

This message needs PLURAL support now.

#Comment by Yaron K. (talk | contribs)   16:10, 6 January 2010

Hi, I don't think so - the message reads something like, "the default number of columns is $1", so I think it would be the same regardless of the number. I'm not an expert on languages, though, so I could be wrong - feel free to change it.

Status & tagging log