r60666 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r60665‎ | r60666 | r60667 >
Date:15:06, 5 January 2010
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
svn:eol-style native
Modified paths:
  • /trunk/phase3/serialized/normalize-ar.ser (modified) (history)
  • /trunk/phase3/serialized/normalize-ml.ser (modified) (history)
  • /trunk/phase3/tests/README.ALTERNATIVE (modified) (history)
  • /trunk/phase3/tests/bootstrap.php (modified) (history)
  • /trunk/phase3/tests/phpunit.xml (modified) (history)

Diff [purge]

Property changes on: trunk/phase3/tests/phpunit.xml
___________________________________________________________________
Name: svn:eol-style
11 + native
Property changes on: trunk/phase3/tests/bootstrap.php
___________________________________________________________________
Name: svn:eol-style
22 + native
Property changes on: trunk/phase3/tests/README.ALTERNATIVE
___________________________________________________________________
Name: svn:eol-style
33 + native
Property changes on: trunk/phase3/serialized/normalize-ar.ser
___________________________________________________________________
Name: svn:eol-style
44 + native
Property changes on: trunk/phase3/serialized/normalize-ml.ser
___________________________________________________________________
Name: svn:eol-style
55 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r60682Follow-up r60666 per Nikerabbit and Bryan's comments: change svn:eol-style pr...ialex19:46, 5 January 2010

Comments

#Comment by Bryan (talk | contribs)   15:50, 5 January 2010

I'm not sure if the serialized php files need svn:eol-style native. Looking at the files they are textual, but the php manual refers to them as "byte streams". I couldn't find a formal specification though.

#Comment by Tim Starling (talk | contribs)   23:54, 6 January 2010

If you set the serialized files to eol-style=native, you'd screw them up if they actually had any line breaks in them, because the length of the strings is given in their prefix e.g. "s:9:". The extra \r will make the decoder become misaligned and you'll get garbage.

Status & tagging log