r60177 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60176‎ | r60177 | r60178 >
Date:21:06, 17 December 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Added parameter support for the 'map' format on Special:Ask.
Modified paths:
  • /trunk/extensions/SemanticMaps/QueryPrinters/SM_Mapper.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -35,7 +35,7 @@
3636
3737 // Only initialize the extension when all dependencies are present.
3838 if (defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' )) {
39 - define('SM_VERSION', '0.5');
 39+ define('SM_VERSION', '0.5.1');
4040
4141 $smgScriptPath = $wgScriptPath . '/extensions/SemanticMaps';
4242 $smgIP = $IP . '/extensions/SemanticMaps';
Index: trunk/extensions/SemanticMaps/QueryPrinters/SM_Mapper.php
@@ -21,6 +21,7 @@
2222 global $egMapsDefaultServices, $egMapsServices;
2323
2424 // TODO: allow service parameter to override the default
 25+ // Note: if this is allowed, then the getParameters should only return the base parameters.
2526 if ($format == 'map') $format = $egMapsDefaultServices['qp'];
2627
2728 $service = MapsMapper::getValidService($format, 'qp');
@@ -52,4 +53,8 @@
5354 return $this->queryPrinter->getResultText($res, $outputmode);
5455 }
5556
 57+ public function getParameters() {
 58+ return $this->queryPrinter->getParameters();
 59+ }
 60+
5661 }

Status & tagging log