r60176 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60175‎ | r60176 | r60177 >
Date:20:28, 17 December 2009
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up to r60163 - add new function parameters at the end of the parameter list. And update release notes.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ChangesFeed.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesFeed.php
@@ -18,7 +18,7 @@
1919 $feedTitle, htmlspecialchars( $description ), $wgTitle->getFullUrl() );
2020 }
2121
22 - public function execute( $feed, $rows, $limit=0, $hideminor=false, $namespace='', $lastmod=false, $target='' ) {
 22+ public function execute( $feed, $rows, $limit=0, $hideminor=false, $lastmod=false, $target='', $namespace='' ) {
2323 global $messageMemc, $wgFeedCacheTimeout;
2424 global $wgSitename, $wgLang;
2525
@@ -27,7 +27,7 @@
2828 }
2929
3030 $timekey = wfMemcKey( $this->type, $this->format, 'timestamp' );
31 - $key = wfMemcKey( $this->type, $this->format, $limit, $hideminor, $namespace, $target, $wgLang->getCode() );
 31+ $key = wfMemcKey( $this->type, $this->format, $limit, $hideminor, $target, $wgLang->getCode(), $namespace );
3232
3333 FeedUtils::checkPurge($timekey, $key);
3434
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -117,7 +117,7 @@
118118 $target = isset($opts['target']) ? $opts['target'] : ''; // RCL has targets
119119 if( $feedFormat ) {
120120 list( $feed, $feedObj ) = $this->getFeedObject( $feedFormat );
121 - $feed->execute( $feedObj, $rows, $opts['limit'], $opts['hideminor'], $opts['namespace'], $lastmod, $target );
 121+ $feed->execute( $feedObj, $rows, $opts['limit'], $opts['hideminor'], $lastmod, $target, $opts['namespace'] );
122122 } else {
123123 $this->webOutput( $rows, $opts );
124124 }
Index: trunk/phase3/RELEASE-NOTES
@@ -685,6 +685,8 @@
686686 * (bug 21814) Message shown when rolling back an edit with a deleted username
687687 now shows '(username deleted)' instead of broken user tool links
688688 * (bug 21536) Fixed JavaScript error on Special:Search caused by an incorrect ID
 689+* (bug 21535) RecentChanges RSS feed now always recognises the namespace filter,
 690+ previously it sometimes didn't due to caching.
689691
690692 == API changes in 1.16 ==
691693

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60163(bug 21535) Add 'namespace' to cache key for RecentChanges RSS feed. Patch b...happy-melon15:42, 17 December 2009

Status & tagging log