r60043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r60042‎ | r60043 | r60044 >
Date:20:08, 14 December 2009
Author:raymond
Status:resolved
Tags:
Comment:
* Change <h2> to <strong> for message 'loginerror' because this message is always shown inside a box: either 'errorbox' or 'successbox', never as real h2
No other error message using these boxes has an 'h2' in it.
Modified paths:
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/templates/Userlogin.php
@@ -16,7 +16,7 @@
1717 ?>
1818 <div class="<?php $this->text('messagetype') ?>box">
1919 <?php if ( $this->data['messagetype'] == 'error' ) { ?>
20 - <h2><?php $this->msg('loginerror') ?></h2>
 20+ <?php $this->msg( 'loginerror' )?></strong><br />
2121 <?php } ?>
2222 <?php $this->html('message') ?>
2323 </div>
@@ -138,7 +138,7 @@
139139 ?>
140140 <div class="<?php $this->text('messagetype') ?>box">
141141 <?php if ( $this->data['messagetype'] == 'error' ) { ?>
142 - <h2><?php $this->msg('loginerror') ?></h2>
 142+ <strong><?php $this->msg( 'loginerror' )?></strong><br />
143143 <?php } ?>
144144 <?php $this->html('message') ?>
145145 </div>

Follow-up revisions

RevisionCommit summaryAuthorDate
r60044Follow-up r60043. Add accidently deleted strongraymond20:11, 14 December 2009

Status & tagging log