r59981 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59980‎ | r59981 | r59982 >
Date:23:19, 11 December 2009
Author:dale
Status:deferred
Tags:
Comment:
* fixed path conflict with gadget
Modified paths:
  • /branches/js2-work/phase3/js2/mwEmbed/jsScriptLoader.php (modified) (history)
  • /branches/js2-work/phase3/js2/mwEmbed/mwEmbed.js (modified) (history)
  • /branches/js2-work/phase3/js2/remoteMwEmbed.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js2/mwEmbed/mwEmbed.js
@@ -1615,7 +1615,7 @@
16161616 var mwpath = null;
16171617
16181618 // Check for direct include of the mwEmbed.js
1619 - if ( src.indexOf( 'mwEmbed.js' ) !== -1 ) {
 1619+ if ( src.indexOf( 'mwEmbed.js' ) !== -1 && src.indexOf( 'MediaWiki:Gadget') == -1) {
16201620 mwpath = src.substr( 0, src.indexOf( 'mwEmbed.js' ) );
16211621 }
16221622
Index: branches/js2-work/phase3/js2/mwEmbed/jsScriptLoader.php
@@ -468,7 +468,7 @@
469469 }
470470 }
471471
472 - function getInlineMesgFromClass( $class ){
 472+ function getInlineMsgFromClass( $class ){
473473 $jsmsg = $this->getMsgKeysFromClass( $class );
474474 if( $jsmsg ){
475475 self::getMsgKeys ( $jsmsg );
Index: branches/js2-work/phase3/js2/remoteMwEmbed.js
@@ -5,7 +5,7 @@
66
77 var urlparts = getRemoteEmbedPath();
88 var mwEmbedHostPath = urlparts[0];
9 -var mwRemoteVersion = '1.1b';
 9+var mwRemoteVersion = '1.1c';
1010 var mwUseScriptLoader = true;
1111
1212 // Setup up request Params:
@@ -29,8 +29,7 @@
3030
3131 function doPageSpecificRewrite() {
3232 // Add media wizard
33 - if ( wgAction == 'edit' || wgAction == 'submit' ) {
34 - var jsSetEdit =
 33+ if ( wgAction == 'edit' || wgAction == 'submit' ) {
3534 loadMwEmbed( [
3635 'remoteSearchDriver',
3736 '$j.fn.textSelection',

Status & tagging log