r59980 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59979‎ | r59980 | r59981 >
Date:22:47, 11 December 2009
Author:dale
Status:deferred
Tags:
Comment:
* getInlineLoadGMFromClass -> getInlineMsgFromClass
Modified paths:
  • /branches/js2-work/phase3/includes/OutputPage.php (modified) (history)
  • /branches/js2-work/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/skins/common/wikibits.js
@@ -36,7 +36,7 @@
3737 var onloadFuncts = [];
3838 }
3939
40 -// code that is dependent on js2 functions should use js2AddOnloadHook
 40+// code that is dependent on js2 functions should use mw.addOnloadHook
4141 function addOnloadHook(hookFunct) {
4242 // Allows add-on scripts to add onload functions
4343 if(!doneOnloadHook) {
Index: branches/js2-work/phase3/includes/OutputPage.php
@@ -245,7 +245,7 @@
246246 if( !$this->mScriptLoader )
247247 $this->mScriptLoader = new jsScriptLoader();
248248
249 - $inlineMsg = $this->mScriptLoader->getInlineLoadGMFromClass( $js_class );
 249+ $inlineMsg = $this->mScriptLoader->getInlineMsgFromClass( $js_class );
250250 if( $inlineMsg != '' )
251251 $this->addScript( Html::inlineScript( $inlineMsg ));
252252 }

Status & tagging log