r59954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59953‎ | r59954 | r59955 >
Date:16:47, 11 December 2009
Author:freakolowsky
Status:ok
Tags:
Comment:
Fixed missing table in ora/tables.sql. Replaced instantiation of DBUndexpecedError with DBQueryError in reportQueryError function
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)
  • /trunk/phase3/maintenance/ora/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/ora/tables.sql
@@ -185,6 +185,13 @@
186186 CREATE INDEX &mw_prefix.externallinks_i02 ON &mw_prefix.externallinks (el_to, el_from);
187187 CREATE INDEX &mw_prefix.externallinks_i03 ON &mw_prefix.externallinks (el_index);
188188
 189+CREATE TABLE &mw_prefix.external_user (
 190+ eu_local_id NUMBER NOT NULL,
 191+ eu_external_id varchar2(255) NOT NULL
 192+);
 193+ALTER TABLE &mw_prefix.external_user ADD CONSTRAINT &mw_prefix.external_user_pk PRIMARY KEY (eu_local_id);
 194+CREATE UNIQUE INDEX &mw_prefix.external_user_u01 ON &mw_prefix.external_user (eu_external_id);
 195+
189196 CREATE TABLE &mw_prefix.langlinks (
190197 ll_from NUMBER NOT NULL REFERENCES &mw_prefix.page (page_id) ON DELETE CASCADE,
191198 ll_lang VARCHAR2(20),
Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -779,11 +779,7 @@
780780 $this->ignoreErrors( $ignore );
781781 }
782782 else {
783 - $message = "A database error has occurred\n" .
784 - "Query: $sql\n" .
785 - "Function: $fname\n" .
786 - "Error: $errno $error\n";
787 - throw new DBUnexpectedError( $this, $message );
 783+ throw new DBQueryError($this, $error, $errno, $sql, $fname);
788784 }
789785 }
790786

Status & tagging log