r59953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59952‎ | r59953 | r59954 >
Date:15:47, 11 December 2009
Author:catrope
Status:ok
Tags:
Comment:
API: (bug 21817) list=usercontribs chokes on empty ucuser. Patch by Paul Copperman. Backported from wmf-deployment (r59952)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryUserContributions.php
@@ -45,7 +45,6 @@
4646 $fld_patrolled = false, $fld_tags = false;
4747
4848 public function execute() {
49 -
5049 // Parse some parameters
5150 $this->params = $this->extractRequestParams();
5251
@@ -74,6 +73,8 @@
7574 $this->usernames = array();
7675 if(!is_array($this->params['user']))
7776 $this->params['user'] = array($this->params['user']);
 77+ if(!count($this->params['user']))
 78+ $this->dieUsage('User parameter may not be empty.', 'param_user');
7879 foreach($this->params['user'] as $u)
7980 $this->prepareUsername($u);
8081 $this->prefixMode = false;
Property changes on: trunk/phase3/includes/api
___________________________________________________________________
Name: svn:mergeinfo
8182 + /branches/REL1_15/phase3/includes/api:51646
/branches/sqlite/includes/api:58211-58321
/branches/wmf-deployment/includes/api:53381,59952
Index: trunk/phase3/RELEASE-NOTES
@@ -743,6 +743,7 @@
744744 * (bug 20967) action=edit allows creation of invalid titles
745745 * (bug 19523) Add inprop=watched to prop=info
746746 * (bug 21589) API: Separate summary and initial page text for uploads
 747+* (bug 21817) list=usercontribs returns empty result for empty ucuser
747748
748749 === Languages updated in 1.16 ===
749750

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59952wmf-deployment: Commit live hack for bug 21817 (API list=usercontribs chokes ...catrope15:44, 11 December 2009

Status & tagging log