r59931 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59930‎ | r59931 | r59932 >
Date:17:23, 10 December 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed order of mw define in js2 stopgap
Modified paths:
  • /branches/js2-work/phase3/js2/editPage.js (modified) (history)
  • /branches/js2-work/phase3/js2/js2stopgap.js (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/js2/js2stopgap.js
@@ -9459,6 +9459,16 @@
94609460 * the JavaScript space. As such, if we get to the point of merging that stuff
94619461 * into the main branch this code will be uneeded and probably cause issues.
94629462 */
 9463+
 9464+/**
 9465+ * Mimics the no-conflict method used by the js2 stuff
 9466+*/
 9467+$j = jQuery.noConflict();
 9468+
 9469+if( !mw )
 9470+ mw = { };
 9471+
 9472+
94639473 // Creates global message object if not already in existence
94649474 if ( !gMsg ) var gMsg = {};
94659475 /**
@@ -9493,14 +9503,7 @@
94949504 return '[' + key + ']';
94959505 }
94969506 }
9497 -/**
9498 - * Mimics the no-conflict method used by the js2 stuff
9499 - */
9500 -$j = jQuery.noConflict();
95019507
9502 -if( !mw )
9503 - mw = { };
9504 -
95059508 /**
95069509 * Provides js2 compatible onload hook
95079510 * @param func Function to call when ready
Index: branches/js2-work/phase3/js2/editPage.js
@@ -23,7 +23,7 @@
2424 mw.addOnloadHook( function() {
2525 js_log( "edit page mw.addOnloadHook::" );
2626 var amwConf = $j.extend( true, defaultAddMediaConfig, mwAddMediaConfig );
27 - // kind of tricky, it would be nice to use run on ready "loader" call here
 27+ // Kind of tricky, it would be nice to use run on ready "loader" call here
2828 var didWikiEditorBind = false;
2929
3030 // Set-up the drag drop binding (will only work for html5 upload browsers)

Status & tagging log