r59844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59843‎ | r59844 | r59845 >
Date:19:44, 8 December 2009
Author:tparscal
Status:ok
Tags:
Comment:
Fixed unsafe testing for undefined.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.preview.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.preview.js
@@ -47,9 +47,9 @@
4848 },
4949 function( data ) {
5050 if (
51 - data.parse == undefined ||
52 - data.parse.text == undefined ||
53 - data.parse.text['*'] == undefined
 51+ typeof data.parse == 'undefined' ||
 52+ typeof data.parse.text == 'undefined' ||
 53+ typeof data.parse.text['*'] == 'undefined'
5454 ) {
5555 return;
5656 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r59849UsabilityInitiative: Recombine and bump style versions for r59838, r59839, r5...catrope20:58, 8 December 2009

Status & tagging log