r59841 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59840‎ | r59841 | r59842 >
Date:19:25, 8 December 2009
Author:tparscal
Status:ok
Tags:
Comment:
Fixed 1px wiggling effect on expand and collapse of TOC.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toc.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toc.js
@@ -119,11 +119,10 @@
120120 var $this = $( this ), context = $this.data( 'context' ),
121121 pT = $this.parent().position().top - 1;
122122 $this.parent()
123 - .css( 'position', 'absolute' )
124 - .css( { 'left': 'auto', 'right': 0, 'top': pT } )
 123+ .css( { 'marginTop': '1px', 'position': 'absolute', 'left': 'auto', 'right': 0, 'top': pT } )
125124 .fadeOut( 'fast', function() {
126125 $( this ).hide()
127 - .css( 'width', '1px' );
 126+ .css( { 'marginTop': '0', 'width': '1px' } );
128127 context.$ui.find( '.wikiEditor-ui-toc-expandControl' ).fadeIn( 'fast' );
129128 } )
130129 .prev()
@@ -150,9 +149,10 @@
151150 context.$ui.find( '.wikiEditor-ui-toc-expandControl' ).hide();
152151 $this.parent()
153152 .show()
 153+ .css( 'marginTop', '1px' )
154154 .animate( { 'width' : openWidth }, 'fast', function() {
155155 context.$content.trigger( 'mouseup' );
156 - $( this ).css( { 'position': 'relative', 'right': 'auto', 'top': 'auto' } );
 156+ $( this ).css( { 'marginTop': '0', 'position': 'relative', 'right': 'auto', 'top': 'auto' } );
157157 // Let the UI know things have moved around
158158 context.fn.trigger( 'resize' );
159159 } )

Follow-up revisions

RevisionCommit summaryAuthorDate
r59849UsabilityInitiative: Recombine and bump style versions for r59838, r59839, r5...catrope20:58, 8 December 2009

Status & tagging log