r59758 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59757‎ | r59758 | r59759 >
Date:15:03, 5 December 2009
Author:maxsem
Status:ok
Tags:
Comment:
Updated links for pages moved from Meta to mw.org, tweaked doc a bit in one case (extensions/ConfirmEdit/MathCaptcha)
Modified paths:
  • /trunk/extensions/Blahtex/README (modified) (history)
  • /trunk/extensions/ConfirmEdit/MathCaptcha (modified) (history)
  • /trunk/extensions/DynamicPageList/DPLMain.php (modified) (history)
  • /trunk/extensions/FCKeditor/plugins/mediawiki/dialogs/special.html (modified) (history)
  • /trunk/extensions/FCKeditor/plugins/mediawiki/fckplugin.js (modified) (history)
  • /trunk/extensions/Poem/Poem.php (modified) (history)
  • /trunk/extensions/SemanticDrilldown/INSTALL (modified) (history)
  • /trunk/extensions/SemanticForms/INSTALL (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/INSTALL (modified) (history)
  • /trunk/extensions/SpamDiffTool/README (modified) (history)
  • /trunk/extensions/ee/ee.pl (modified) (history)
  • /trunk/extensions/gis/gisversion.php (modified) (history)
  • /trunk/phase3/HISTORY (modified) (history)
  • /trunk/phase3/docs/skin.txt (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/maintenance/language/transstat.php (modified) (history)
  • /trunk/phase3/maintenance/syntaxChecker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/syntaxChecker.php
@@ -26,6 +26,7 @@
2727
2828 // List of files we're going to check
2929 private $mFiles = array(), $mFailures = array(), $mWarnings = array();
 30+ private $mIgnorePaths = array(), $mNoStyleCheckPaths = array();
3031
3132 public function __construct() {
3233 parent::__construct();
@@ -70,6 +71,25 @@
7172 private function buildFileList() {
7273 global $IP;
7374
 75+ $this->mIgnorePaths = array(
 76+ // Compat stuff, explodes on PHP 5.3
 77+ "includes/NamespaceCompat.php$",
 78+ "DiscussionThreading/REV",
 79+ );
 80+
 81+ $this->mNoStyleCheckPaths = array(
 82+ // Third-party code we don't care about
 83+ "/activemq_stomp/",
 84+ "EmailPage/phpMailer",
 85+ "FCKeditor/fckeditor/",
 86+ '\bphplot-',
 87+ "/svggraph/",
 88+ "\bjsmin.php$",
 89+ "OggHandler/PEAR/",
 90+ "QPoll/Excel/",
 91+ "/smarty/",
 92+ );
 93+
7494 if ( $this->hasOption( 'path' ) ) {
7595 $path = $this->getOption( 'path' );
7696 if ( !$this->addPath( $path ) ) {
Index: trunk/phase3/maintenance/language/transstat.php
@@ -9,7 +9,7 @@
1010 * @author Ashar Voultoiz <thoane@altern.org>
1111 *
1212 * Output is posted from time to time on:
13 - * http://meta.wikimedia.org/wiki/Localization_statistics
 13+ * http://www.mediawiki.org/wiki/Localisation_statistics
1414 */
1515 $optionsWithArgs = array( 'output' );
1616
Index: trunk/phase3/docs/skin.txt
@@ -47,7 +47,7 @@
4848 This feature has led to a wide variety of "user styles" becoming available,
4949 which change the appearance of Monobook or MySkin:
5050
51 -http://meta.wikimedia.org/wiki/Gallery_of_user_styles
 51+http://www.mediawiki.org/wiki/Manual:Gallery_of_user_styles
5252
5353 If you want a different look for your wiki, that gallery is a good place to start.
5454
Index: trunk/phase3/HISTORY
@@ -5756,7 +5756,7 @@
57575757 groups. Note that this does *not* allow you to make pages which are only
57585758 accessible to certain groups.
57595759
5760 - For details see: http://meta.wikimedia.org/wiki/Help:User_rights
 5760+ For details see: http://www.mediawiki.org/wiki/Manual:User_rights
57615761
57625762 E-mail:
57635763 User-to-user e-mail can now be restricted to require a mail-back confirmation
@@ -6006,8 +6006,8 @@
60076007
60086008 * 'live preview' reduces preview reload burden on supported browsers
60096009 * support for external editors for files and wiki pages:
6010 - http://meta.wikimedia.org/wiki/Help:External_editors
6011 -* Schema reworking: http://meta.wikimedia.org/wiki/Proposed_Database_Schema_Changes/October_2004
 6010+ http://www.mediawiki.org/wiki/Manual:External_editors
 6011+* Schema reworking: http://www.mediawiki.org/wiki/Proposed_Database_Schema_Changes/October_2004
60126012 * (bug 15) Allow editors to view diff of their change before actually submitting an edit
60136013 * (bug 190) Hide your own edits on the watchlist
60146014 * (bug 510): Special:Randompage now works for other namespaces than NS_MAIN.
@@ -6690,7 +6690,7 @@
66916691 If you have trouble, remember to read this whole file and the online FAQ page
66926692 before asking for help:
66936693
6694 -http://meta.wikimedia.org/wiki/MediaWiki_FAQ
 6694+http://www.mediawiki.org/wiki/Manual:FAQ
66956695
66966696
66976697 === READ THIS FIRST: Upgrading ===
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1263,7 +1263,7 @@
12641264 * as a valid article? If $wgUseCommaCount is set to true, it will be
12651265 * counted if it contains at least one comma. If it is set to false
12661266 * (default), it will only be counted if it contains at least one [[wiki
1267 - * link]]. See http://meta.wikimedia.org/wiki/Help:Article_count
 1267+ * link]]. See http://www.mediawiki.org/wiki/Manual:Article_count
12681268 *
12691269 * Retroactively changing this variable will not affect
12701270 * the existing count (cf. maintenance/recount.sql).
@@ -3449,7 +3449,7 @@
34503450
34513451 /**
34523452 * Activate external editor interface for files and pages
3453 - * See http://meta.wikimedia.org/wiki/Help:External_editors
 3453+ * See http://www.mediawiki.org/wiki/Manual:External_editors
34543454 */
34553455 $wgUseExternalEditor = true;
34563456
Index: trunk/extensions/gis/gisversion.php
@@ -40,7 +40,7 @@
4141 $wgOut->setPagetitle( "Version" );
4242 $wgOut->addHTML( '
4343 <p><b><a href="http://www.mediawiki.org/">MediaWiki</a></b>
44 - <a href="http://meta.wikimedia.org/wiki/Gis">GIS extension</a>,
 44+ <a href="http://www.mediawiki.org/wiki/Extension:Gis">GIS extension</a>,
4545 copyright (C) 2005 by Egil Kvaleberg.</p>
4646
4747 <p>The GIS extension is free software; you can redistribute it and/or modify
Index: trunk/extensions/SemanticMediaWiki/INSTALL
@@ -93,7 +93,7 @@
9494 [SMW_path]/maintenance/README for details on how to run such scripts.
9595
9696 '''Remark:''' Semantic MediaWiki uses ten additional namespace indexes (see
97 -http://meta.wikimedia.org/wiki/Help:Custom_namespaces), in the range from
 97+http://www.mediawiki.org/wiki/Manual:Using_custom_namespaces), in the range from
9898 100 to 109. 100 and 101 are not used (they were used in early beta versions).
9999 106 and 107 are reserved for the SemanticForms extension. If you have your own
100100 custom namespaces, you have to set the parameter $smwgNamespaceIndex before
Index: trunk/extensions/ConfirmEdit/MathCaptcha
@@ -34,7 +34,7 @@
3535 extensions/ directory, within your wiki root.
3636
3737 Edit LocalSettings.php and add the following lines near the bottom of the
38 -file, above the closing ?> tag:
 38+file, above the closing ?> tag, if any:
3939
4040 require_once( 'extensions/ConfirmEdit.php' );
4141 require_once( 'extensions/MathCaptcha.php' );
@@ -71,6 +71,6 @@
7272 == 7. References ==
7373
7474 i. http://en.wikipedia.org/wiki/Captcha
75 -ii. http://meta.wikimedia.org/wiki/ConfirmEdit
76 -iii. http://meta.wikimedia.org/wiki/Enable_TeX
 75+ii. http://www.mediawiki.org/wiki/Extension:ConfirmEdit
 76+iii. http://www.mediawiki.org/wiki/Manual:Enable_TeX
7777 iv. http://www.mediawiki.org/wiki/Subversion
Index: trunk/extensions/SemanticForms/INSTALL
@@ -30,7 +30,7 @@
3131 include_once('extensions/SemanticForms/includes/SF_Settings.php');
3232
3333 '''Remark:''' Semantic Forms creates an additional custom namespace, "Form"
34 -(see http://meta.wikimedia.org/wiki/Help:Custom_namespaces). If you have your
 34+(see http://www.mediawiki.org/wiki/Manual:Using_custom_namespaces). If you have your
3535 own custom namespaces, you have to set the parameter $sfgNamespaceIndex before
3636 including SF_Settings.php. See SF_Settings.php for more details.
3737
Index: trunk/extensions/Blahtex/README
@@ -12,7 +12,7 @@
1313 tags. It also recognizes some additional LaTeX commands.
1414
1515 See the manual (in the file manual.tex) and
16 -http://meta.wikimedia.org/wiki/Blahtex for more details.
 16+http://www.mediawiki.org/wiki/Extension:Blahtex for more details.
1717
1818
1919 Brief installation instructions:
Index: trunk/extensions/SpamDiffTool/README
@@ -7,7 +7,7 @@
88 mediawiki=1.6+
99 Allows users to add entries to the Spam blacklist right off of a diff page
1010
11 -This extension allows users to add URLs to the Spam Blacklist (see the Spamblacklist Extension http://meta.wikimedia.org/wiki/SpamBlacklist_extension) easily without learning how to format entries for the blacklist and copy and paste, etc. By inserting a link on each diff page, if an editor sees that a given page has been the victim of spam, they can click on "add to spam", which extracts all of the URLs the spammer has placed on the page, going back over their most recent edits on the article (similar to Rollback). Then, for each URL detected, the tool prompts the user the degree to which they want to blacklist the URL. The options are block:
 11+This extension allows users to add URLs to the Spam Blacklist (see the Spamblacklist Extension http://www.mediawiki.org/wiki/Extension:SpamBlacklist) easily without learning how to format entries for the blacklist and copy and paste, etc. By inserting a link on each diff page, if an editor sees that a given page has been the victim of spam, they can click on "add to spam", which extracts all of the URLs the spammer has placed on the page, going back over their most recent edits on the article (similar to Rollback). Then, for each URL detected, the tool prompts the user the degree to which they want to blacklist the URL. The options are block:
1212
1313 # all links from the domain
1414 # all links from the specific subdomain
Index: trunk/extensions/ee/ee.pl
@@ -5,8 +5,8 @@
66 #
77 # written by Erik M�ller - public domain
88 #
9 -# User documentation: http://meta.wikimedia.org/wiki/Help:External_editors
10 -# Technical documentation: http://meta.wikimedia.org/wiki/Help:External_editors/Tech
 9+# User documentation: http://www.mediawiki.org/wiki/Manual:External_editors
 10+# Technical documentation: http://www.mediawiki.org/wiki/Manual:External_editors:_control_files
1111 #
1212 # To do: Edit conflicts
1313 #
Index: trunk/extensions/FCKeditor/plugins/mediawiki/dialogs/special.html
@@ -151,7 +151,7 @@
152152 if (tagName == 'inputbox')
153153 {
154154 if (!FCKLang.inputboxHelp) FCKLang.inputboxHelp = 'Inputbox allows to create a form for users to create new pages. The new pages edit box can be pre-loaded with any template. See %link for details';
155 - GetE('xDefinition').innerHTML = FCKLang.inputboxHelp.replace( /%link/g, '<a href="#" onclick="javascript:window.open(\'http://meta.wikimedia.org/wiki/Help:Inputbox\')">manual</a>' ) ;
 155+ GetE('xDefinition').innerHTML = FCKLang.inputboxHelp.replace( /%link/g, '<a href="#" onclick="javascript:window.open(\'http://www.mediawiki.org/wiki/Extension:InputBox\')">manual</a>' ) ;
156156 }
157157 }
158158
Index: trunk/extensions/FCKeditor/plugins/mediawiki/fckplugin.js
@@ -25,7 +25,7 @@
2626 * http://meta.wikimedia.org/wiki/Help:Advanced_editing
2727 *
2828 * MediaWiki Sandbox:
29 - * http://meta.wikimedia.org/wiki/Meta:Sandbox
 29+ * http://www.mediawiki.org/wiki/Sandbox
3030 */
3131
3232 // Rename the "Source" buttom to "Wikitext".
Index: trunk/extensions/SemanticDrilldown/INSTALL
@@ -31,7 +31,7 @@
3232 include_once('extensions/SemanticDrilldown/includes/SD_Settings.php');
3333
3434 '''Remark:''' Semantic Drilldown creates an additional custom namespace,
35 -"Filter" (see http://meta.wikimedia.org/wiki/Help:Custom_namespaces). If
 35+"Filter" (see http://www.mediawiki.org/wiki/Manual:Using_custom_namespaces). If
3636 you have your own custom namespaces, you have to set the parameter
3737 $sdgNamespaceIndex before including SD_Settings.php. See SD_Settings.php
3838 for more details.
Index: trunk/extensions/Poem/Poem.php
@@ -2,7 +2,7 @@
33 # MediaWiki Poem extension v1.0cis
44 #
55 # Based on example code from
6 -# http://meta.wikimedia.org/wiki/Write_your_own_MediaWiki_extension
 6+# http://www.mediawiki.org/wiki/Manual:Extending_wiki_markup
77 #
88 # All other code is copyright © 2005 Nikola Smolenski <smolensk@eunet.yu>
99 # (with modified parser callback and attribute additions)
@@ -16,7 +16,7 @@
1717 # To use, put some text between <poem></poem> tags
1818 #
1919 # For more information see its page at
20 -# http://meta.wikimedia.org/wiki/Poem_Extension
 20+# http://www.mediawiki.org/wiki/Extension:Poem
2121
2222 $wgHooks['ParserFirstCallInit'][] = 'wfPoemExtension';
2323 $wgExtensionCredits['parserhook'][] = array(
Index: trunk/extensions/DynamicPageList/DPLMain.php
@@ -42,7 +42,7 @@
4343
4444 $dplStartTime= microtime(true);
4545
46 - // Local parser created. See http://meta.wikimedia.org/wiki/MediaWiki_extensions_FAQ#How_do_I_render_wikitext_in_my_extension.3F
 46+ // Local parser created. See http://www.mediawiki.org/wiki/Extensions_FAQ#How_do_I_render_wikitext_in_my_extension.3F
4747 $localParser = new Parser();
4848 $pOptions = $parser->mOptions;
4949 $pTitle = $parser->mTitle;

Follow-up revisions

RevisionCommit summaryAuthorDate
r60580Let's use the variables introduced in r59758 :)ialex15:02, 3 January 2010

Status & tagging log