r59750 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59749‎ | r59750 | r59751 >
Date:02:37, 5 December 2009
Author:tomasz
Status:ok (Comments)
Tags:
Comment:
Field 4 is actually max not min. Not using field 5 for now
Modified paths:
  • /trunk/extensions/ContributionReporting/ContributionStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributionReporting/ContributionStatistics_body.php
@@ -415,8 +415,8 @@
416416 $totals['USD'][1] += $totals[null][1];
417417 $totals['USD'][2] += $totals[null][2];
418418 $totals['USD'][3] = ( $totals['USD'][3] + $totals[null][3] ) / 2;
419 - $totals['USD'][4] = min( $totals['USD'][4], $totals[null][4] );
420 - $totals['USD'][5] = max( $totals['USD'][5], $totals[null][5] );
 419+ $totals['USD'][4] = max( $totals['USD'][4], $totals[null][4] );
 420+ /* $totals['USD'][5] = min( $totals['USD'][5], $totals[null][5] ); */
421421 unset( $totals[null] );
422422 }
423423

Follow-up revisions

RevisionCommit summaryAuthorDate
r59753picking up r59750, 59165, 59751, 59752 and new translations.tomasz03:22, 5 December 2009

Comments

#Comment by Tim Starling (talk | contribs)   22:49, 8 December 2009

This is what constants are for.

Status & tagging log