r59621 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59620‎ | r59621 | r59622 >
Date:08:12, 1 December 2009
Author:aaron
Status:deferred
Tags:
Comment:
Follow up r56372: use addQuotes() to make sql escaping clear (value is already an int)
Modified paths:
  • /trunk/extensions/ReaderFeedback/specialpages/RatedPages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ReaderFeedback/specialpages/RatedPages_body.php
@@ -136,7 +136,7 @@
137137 default: $conds[] = "rfp_ave_val >= 2 AND rfp_ave_val <= 3"; break;
138138 }
139139 // Reasonable samples only
140 - $conds[] = 'rfp_count >= '.ReaderFeedback::getFeedbackSize();
 140+ $conds[] = 'rfp_count >= '.$this->mDb->addQuotes( ReaderFeedback::getFeedbackSize() );
141141 return array(
142142 'tables' => array('reader_feedback_pages','page'),
143143 'fields' => 'page_namespace,page_title,page_len,rfp_ave_val,rfp_count',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56372Added $wgFeedbackSizeThreshholdaaron17:13, 15 September 2009

Status & tagging log