r59620 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59619‎ | r59620 | r59621 >
Date:08:03, 1 December 2009
Author:aaron
Status:ok
Tags:
Comment:
Reverted return style changes from r56326 (just used to reduce code lines)
Modified paths:
  • /trunk/extensions/ReaderFeedback/specialpages/RatedPages_body.php (modified) (history)
  • /trunk/extensions/ReaderFeedback/specialpages/ReaderFeedback_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ReaderFeedback/specialpages/RatedPages_body.php
@@ -17,13 +17,16 @@
1818 $this->setHeaders();
1919 if( $wgUser->isAllowed( 'feedback' ) ) {
2020 if( $wgUser->isBlocked() ) {
21 - return $wgOut->blockedPage();
 21+ $wgOut->blockedPage();
 22+ return;
2223 }
2324 } else {
24 - return $wgOut->permissionRequired( 'feedback' );
 25+ $wgOut->permissionRequired( 'feedback' );
 26+ return;
2527 }
2628 if( wfReadOnly() ) {
27 - return $wgOut->readOnlyPage();
 29+ $wgOut->readOnlyPage();
 30+ return;
2831 }
2932 // Purge expired entries on one in every 10 queries
3033 if( 0 == mt_rand( 0, 10 ) ) {
Index: trunk/extensions/ReaderFeedback/specialpages/ReaderFeedback_body.php
@@ -27,13 +27,16 @@
2828 $confirm = $wgRequest->wasPosted() && $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) );
2929 if( $wgUser->isAllowed( 'feedback' ) ) {
3030 if( $wgUser->isBlocked( !$confirm ) ) {
31 - return $wgOut->blockedPage();
 31+ $wgOut->blockedPage();
 32+ return;
3233 }
3334 } else {
34 - return $wgOut->permissionRequired( 'feedback' );
 35+ $wgOut->permissionRequired( 'feedback' );
 36+ return;
3537 }
3638 if( wfReadOnly() ) {
37 - return $wgOut->readOnlyPage();
 39+ $wgOut->readOnlyPage();
 40+ return;
3841 }
3942 $this->setHeaders();
4043 # Our target page

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56326* Rate-limit review...aaron19:34, 14 September 2009

Status & tagging log