r59592 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59591‎ | r59592 | r59593 >
Date:18:37, 30 November 2009
Author:root
Status:ok (Comments)
Tags:
Comment:
* Rename knams into esams
* As root, just to annoy Roan
Modified paths:
  • /trunk/ubuntu/autoinstall/esams.cfg (added) (history)
  • /trunk/ubuntu/autoinstall/knams.cfg (deleted) (history)
  • /trunk/ubuntu/autoinstall/netboot.cfg (modified) (history)

Diff [purge]

Index: trunk/ubuntu/autoinstall/knams.cfg
@@ -1,34 +0,0 @@
2 -# knams specific configuration settings
3 -
4 -# Select interface that has a link
5 -d-i netcfg/choose_interface select auto
6 -
7 -d-i netcfg/disable_dhcp boolean true
8 -# ip address is taken from DHCP, rest is set here
9 -d-i netcfg/get_domain string knams.wikimedia.org
10 -d-i netcfg/get_netmask string 255.255.255.128
11 -d-i netcfg/get_gateway string 91.198.174.1
12 -d-i netcfg/get_nameservers string 91.198.174.6 208.80.152.131
13 -d-i netcfg/confirm_static boolean true
14 -
15 -# get_domain should be set, get_hostname is overwritten by DHCP
16 -#d-i netcfg/get_hostname string unassigned-hostname
17 -d-i netcfg/get_domain string knams.wikimedia.org
18 -
19 -d-i netcfg/wireless_wep string
20 -
21 -### Mirror settings
22 -d-i mirror/country select NL
23 -d-i mirror/http/countries select NL
24 -d-i mirror/http/mirror select nl.archive.ubuntu.com
25 -d-i mirror/http/directory string /ubuntu/
26 -d-i mirror/http/proxy string
27 -
28 -d-i apt-setup/security_host string security.ubuntu.com
29 -
30 -# NTP
31 -d-i clock-setup/ntp-server string ntp.knams.wikimedia.org
32 -
33 -# ssmtp settings
34 -ssmtp ssmtp/mailhub string pascal.knams.wikimedia.org
35 -ssmtp ssmtp/fromoverride boolean true
Index: trunk/ubuntu/autoinstall/esams.cfg
@@ -0,0 +1,34 @@
 2+# esams specific configuration settings
 3+
 4+# Select interface that has a link
 5+d-i netcfg/choose_interface select auto
 6+
 7+d-i netcfg/disable_dhcp boolean true
 8+# ip address is taken from DHCP, rest is set here
 9+d-i netcfg/get_domain string esams.wikimedia.org
 10+d-i netcfg/get_netmask string 255.255.255.128
 11+d-i netcfg/get_gateway string 91.198.174.1
 12+d-i netcfg/get_nameservers string 91.198.174.6 208.80.152.131
 13+d-i netcfg/confirm_static boolean true
 14+
 15+# get_domain should be set, get_hostname is overwritten by DHCP
 16+#d-i netcfg/get_hostname string unassigned-hostname
 17+d-i netcfg/get_domain string esams.wikimedia.org
 18+
 19+d-i netcfg/wireless_wep string
 20+
 21+### Mirror settings
 22+d-i mirror/country select NL
 23+d-i mirror/http/countries select NL
 24+d-i mirror/http/mirror select nl.archive.ubuntu.com
 25+d-i mirror/http/directory string /ubuntu/
 26+d-i mirror/http/proxy string
 27+
 28+d-i apt-setup/security_host string security.ubuntu.com
 29+
 30+# NTP
 31+d-i clock-setup/ntp-server string ntp.esams.wikimedia.org
 32+
 33+# ssmtp settings
 34+ssmtp ssmtp/mailhub string pascal.esams.wikimedia.org
 35+ssmtp ssmtp/fromoverride boolean true
Index: trunk/ubuntu/autoinstall/netboot.cfg
@@ -3,5 +3,5 @@
44 # Generally we'll do a basic server install.
55 d-i preseed/include string common.cfg passwd.cfg override.cfg
66
7 -d-i preseed/include_command string case $(ip address show dev eth0 | egrep '^[[:space:]]+inet' | cut -d ' ' -f 8) in 208.80.152.191) echo pmtpa.cfg ;; 208.80.152.127) echo pmtpa-squid.cfg ;; 10.0.255.255) echo pmtpa-internal.cfg ;; 91.198.174.127) echo knams.cfg ;; esac; case $(debconf-get netcfg/get_hostname) in sq*|knsq*) echo squid.cfg ;; db*) echo db.cfg ;; srv15[123]) echo apache.cfg ;; esac
 7+d-i preseed/include_command string case $(ip address show dev eth0 | egrep '^[[:space:]]+inet' | cut -d ' ' -f 8) in 208.80.152.191) echo pmtpa.cfg ;; 208.80.152.127) echo pmtpa-squid.cfg ;; 10.0.255.255) echo pmtpa-internal.cfg ;; 91.198.174.127) echo esams.cfg ;; esac; case $(debconf-get netcfg/get_hostname) in sq*|knsq*) echo squid.cfg ;; db*) echo db.cfg ;; srv15[123]) echo apache.cfg ;; esac
88

Comments

#Comment by Tim Starling (talk | contribs)   05:29, 2 December 2009

I don't think Roan is the only person you're annoying. I've configured the repository to stop accepting commits from root.

#Comment by 😂 (talk | contribs)   17:05, 3 December 2009

I suppose it's a non-issue now since root can't commit anymore, but I was going to ask who we should tie the "root" committer to for Code Review. I figured Mark but I wasn't sure.

#Comment by Tim Starling (talk | contribs)   23:16, 3 December 2009

Well, r59104 has Mark's name on it, and r54108 says Fred. r55852 could have been one of those two, or it could have been Domas. It's hard to say.

Status & tagging log