r59530 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r59529‎ | r59530 | r59531 >
Date:20:20, 28 November 2009
Author:philip
Status:deferred (Comments)
Tags:
Comment:
follow-up r59522, r59529. Just include the current variant.
Modified paths:
  • /trunk/phase3/languages/LanguageConverter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/LanguageConverter.php
——@@ -243,13 +243,7 @@
244244 global $wgOut, $wgUseXVO;
245245 $wgOut->addVaryHeader( 'Accept-Language' );
246246 if( $wgUseXVO ) {
247 - $aloption = array();
248 - foreach( $this->mVariants as $variant ) {
249 - if($variant === $this->mMainLanguageCode)
250 - continue;
251 - $aloption[] = 'string-contains=' . $variant;
252 - }
253 - $wgOut->addXVOHeader( 'Accept-Language', $aloption );
 247+ $wgOut->addXVOHeader( 'Accept-Language', array($ret_language) );
254248 }
255249 }
256250 return $ret_language;

Follow-up revisions

RevisionCommit summaryAuthorDate
r59541follow-up r59522, r59523, r59527, r59529, r59530....philip06:47, 29 November 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59522bug 21672: Add Accept-Language to Vary and XVO headers to help Squid to deter...philip19:13, 28 November 2009
r59529follow-up r59522. "string-contains" added.philip20:13, 28 November 2009

Comments

#Comment by Catrope (talk | contribs)   21:40, 28 November 2009

I'm still not convinced this'll work correctly. I'll ask Mark to look at this.

#Comment by PhiLiP (talk | contribs)   23:45, 28 November 2009

ok...

#Comment by PhiLiP (talk | contribs)   04:04, 29 November 2009

Could this just apply on when "301 moved permanently" happened properly? 301 redirect won't call the parser, and it is the most case we need to ensure it uncacheable.

Status & tagging log