r59446 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59445‎ | r59446 | r59447 >
Date:12:00, 26 November 2009
Author:tstarling
Status:resolved (Comments)
Tags:
Comment:
Removed JS2 work (has been moved to the js2-work branch). Has been lightly tested, should mostly work. Some of the more complicated associated changes are listed below.

* Reverted HttpFunctions.php to r45549 and renamed wgSyncHTTPTimeout back to wgHTTPTimeout
* Edited out the asynchronous features from UploadFromUrl. Made fetchFile() use the curlCopy() function from new-upload r47811 instead of Http::doDownload(). Wrote my own URL validity check to avoid having to use either of the two buggy precedents.
* Removed UploadFromChunk
* Removed chunk upload and background status from ApiUpload.php
* Reverted r54669, use of addScriptClass()
* Left getHeadScripts() in its current location (OutputPage) instead of moving it back to SkinTemplate, just added wikibits.js to it to replace the removed addCoreScripts2Top()
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)
  • /trunk/phase3/includes/HttpFunctions.php (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/Preferences.php (modified) (history)
  • /trunk/phase3/includes/Setup.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUpload.php (modified) (history)
  • /trunk/phase3/includes/filerepo/FSRepo.php (modified) (history)
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /trunk/phase3/includes/filerepo/ForeignAPIRepo.php (modified) (history)
  • /trunk/phase3/includes/filerepo/NullRepo.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadFromChunks.php (deleted) (history)
  • /trunk/phase3/includes/upload/UploadFromUrl.php (modified) (history)
  • /trunk/phase3/js2 (deleted) (history)
  • /trunk/phase3/languages/messages/MessagesAf.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesAr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesArz.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBe_tarask.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBpy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCeb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCkb_arab.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCrh_cyrl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCrh_latn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDiq.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDsb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFrp.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGrc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGsw.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHif_latn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHsb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesId.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesJa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesJv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKiu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKm.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKrc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKsh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLzh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMg.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMk.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNds_nl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesOc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPms.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPt_br.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesRo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesRoa_tara.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesRu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSah.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesScn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSk.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSli.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesStq.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSw.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesTe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesTh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesTk.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesTr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesTt_cyrl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesUk.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesVec.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesVep.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesVi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesWo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesYi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesYo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesYue.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesZh_hans.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesZh_hant.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)
  • /trunk/phase3/mwScriptLoader.php (deleted) (history)
  • /trunk/phase3/mwScriptLoader.php5 (deleted) (history)
  • /trunk/phase3/skins/common/preview.js (deleted) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r59450Partial revert of r59446: add js2stopgap.js back in, some extensions (at leas...catrope14:24, 26 November 2009
r59457Fix fatal error since r59446: replace call to OutputPage::addScriptClass() wi...ialex16:10, 26 November 2009
r59476Did --record-only merges of r59446 and r59450 so that we can later merge the ...tstarling22:57, 26 November 2009
r60394RELEASE-NOTES cleanup:...ialex18:35, 25 December 2009
r60395Readd $wgPhpCli (removed in r59446), it was already here before JS2, and Flag...ialex18:50, 25 December 2009
r62173Reverse removal of Live Preview in r59446, with the following changes:...werdna07:39, 9 February 2010
r68291Follow-up r59446 (removal of JS2 work): remove messages that were added in r5...siebrand22:22, 19 June 2010
r68292* remove mention of $wgUseAJAXCategories feature from RELEASE-NOTES...siebrand22:28, 19 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45549Fix odd edge case for POST Http::request()'s. I incidentally found this while...demon06:56, 8 January 2009
r47811updated new-upload branch to svn merge -r 46618 : 47809dale21:53, 25 February 2009
r54669Support script loadernikerabbit16:20, 9 August 2009

Comments

#Comment by Catrope (talk | contribs)   14:25, 26 November 2009

Note that this revision deletes skins/common/preview.js , which probably breaks LiquidThreads.

#Comment by Mdale (talk | contribs)   17:52, 30 November 2009

Why where the interfaces for chunk upload and http status upload removed? These interfaces can still be used without the associated JS attached to core. i.e the remote js support of mwEmbed via the mwEmbed gadget makes heavy use of them.

#Comment by Mdale (talk | contribs)   17:27, 4 December 2009

Furthermore these api modules have already been deployed and are being used on the commons site. I don't think its a good idea to remove deployed api features. I will add them back in if it won't be reverted? If there is anything "wrong" with these modules I would be happy to fix that but let me know ~what~ is wrong with them.

#Comment by Tim Starling (talk | contribs)   07:22, 9 February 2010

On closer analysis, chunk upload and async copy upload both turned out to be totally broken, so I think I was justified in removing them.

Werdna is working on restoring the live preview feature.

#Comment by Tim Starling (talk | contribs)   07:52, 22 February 2010

Marking resolved since live preview and LiquidThreads work now, as does every other in-tree extension.

Status & tagging log