r59221 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r59220‎ | r59221 | r59222 >
Date:21:52, 18 November 2009
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Add missing messages for the existing idention icon
What to do to create the .combined.js?
Modified paths:
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.i18n.php
——@@ -65,6 +65,8 @@
6666 'wikieditor-toolbar-tool-ulist-example' => 'Bulleted list item',
6767 'wikieditor-toolbar-tool-olist' => 'Numbered list',
6868 'wikieditor-toolbar-tool-olist-example' => 'Numbered list item',
 69+ 'wikieditor-toolbar-tool-indent' => 'Indention',
 70+ 'wikieditor-toolbar-tool-indent-example' => 'Indented line',
6971 'wikieditor-toolbar-group-size' => 'Size',
7072 'wikieditor-toolbar-tool-big' => 'Big',
7173 'wikieditor-toolbar-tool-big-example' => 'Big text',
Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js
——@@ -244,6 +244,7 @@
245245 type: 'encapsulate',
246246 options: {
247247 pre: ":",
 248+ periMsg: 'wikieditor-toolbar-tool-indent-example',
248249 post: "",
249250 ownline: true
250251 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r59238Fix r59228: somehow it did increment the right style versions and recombine o...catrope10:17, 19 November 2009

Comments

#Comment by Catrope (talk | contribs)   10:18, 19 November 2009

Adam recombined it for you in r59228. For future reference, you can do this by running make in the UsabilityInitiative directory. Also please update the relevant style versions (done in r59238).

Status & tagging log