r59162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59161‎ | r59162 | r59163 >
Date:00:47, 17 November 2009
Author:nimishg
Status:resolved (Comments)
Tags:
Comment:
cc-reporting JS support
Modified paths:
  • /trunk/extensions/ContributionReporting/cc-reporting.js (added) (history)
  • /trunk/extensions/ContributionReporting/cc-reporting.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributionReporting/cc-reporting.php
@@ -18,6 +18,7 @@
1919 }
2020
2121 //if not exist insert into DB
 22+ //via REQUEST['utm_src']
2223 }
2324
2425 function handleSubmit(){
Index: trunk/extensions/ContributionReporting/cc-reporting.js
@@ -0,0 +1,24 @@
 2+
 3+runOnloadHook = function(){
 4+ sendReq("cc-reporting.php?load=1&utm_src=" + document.payment.utm_source.value);
 5+}
 6+
 7+submitForm = function(){
 8+ sendReq("cc-reporting.php?submit=1&utm_src="+ document.payment.utm_source.value);
 9+ return validate_form(document.payment);
 10+}
 11+
 12+sendReq = function(sendRequest){
 13+ if (window.XMLHttpRequest)
 14+ {
 15+   xhttp=new XMLHttpRequest();
 16+   }
 17+ else // Internet Explorer 5/6
 18+ {
 19+ xhttp=new ActiveXObject("Microsoft.XMLHTTP");
 20+ }
 21+ xhttp.open("GET",sendRequest ,false);
 22+ xhttp.send("");
 23+ dummyVar=xhttp.responseXML;
 24+}
 25+
Property changes on: trunk/extensions/ContributionReporting/cc-reporting.js
___________________________________________________________________
Name: svn:eol-style
126 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r60794Per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59183#c4712, these w...demon17:25, 7 January 2010

Comments

#Comment by Tim Starling (talk | contribs)   23:14, 8 December 2009

Missing URL escaping for the utm_source.value parameter.

Status & tagging log