r58991 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58990‎ | r58991 | r58992 >
Date:00:01, 13 November 2009
Author:catrope
Status:deferred
Tags:
Comment:
UsabilityInitiative: (bug 21459) WikiEditor breaks when NTOC disabled. This is why you shouldn't put TOC code in the toolbar module
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
@@ -562,11 +562,11 @@
563563 },
564564 build : function( context, config ) {
565565 var $tabs = $( '<div />' ).addClass( 'tabs' ).appendTo( context.modules.$toolbar );
 566+ /*
566567 if( wgNavigableTOCCollapseEnable ) {
567568 // FIXME: This code is duplicated from the TOC plugin and doesn't belong here;
568569 // the TOC drag thingy should be in the TOC plugin instead
569570 // placeholder for drag control creation code
570 - /*
571571 $dragControl = $( '<div />' ).addClass( 'tab' ).attr( 'id', 'wikiEditor-ui-toc-resize-grip' )
572572 .append( '<a href="#" title="Drag to resize"></a>' )
573573 .mousedown( function() {
@@ -587,8 +587,8 @@
588588 return false;
589589 })
590590 context.modules.$toolbar.append( $dragControl );
591 - */
592591 }
 592+ */
593593 var $sections = $( '<div />' ).addClass( 'sections' ).appendTo( context.modules.$toolbar );
594594 context.modules.$toolbar.append( $( '<div />' ).css( 'clear', 'both' ) );
595595 var sectionQueue = [];

Follow-up revisions

RevisionCommit summaryAuthorDate
r58992Update style versions and recombine for r58991catrope00:02, 13 November 2009
r60316UsabilityInitiative: (bug 21459) Handle 'user' => false in config correctlycatrope15:01, 23 December 2009

Status & tagging log