r58756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58755‎ | r58756 | r58757 >
Date:11:03, 8 November 2009
Author:avar
Status:resolved (Comments)
Tags:
Comment:
* (bug 20112) Mark failing test for resolved bug 18609 as TODO. Is this OK? No idea
Modified paths:
  • /trunk/phase3/t/inc/SearchUpdate.t (modified) (history)

Diff [purge]

Index: trunk/phase3/t/inc/SearchUpdate.t
——@@ -58,4 +58,7 @@
5959 is( updateText( 'a > b' ), 'a b', 'Handle unclosed tags' );
6060
6161 $text = str_pad( "foo <barbarbar \n", 10000, 'x' );
62 -ok( updateText( $text ) != '', 'Bug 18609' );
\ No newline at end of file
 62+
 63+todo_start("Bug 18609");
 64+isnt( updateText( $text ), '', 'Bug 18609' );
 65+todo_end();

Follow-up revisions

RevisionCommit summaryAuthorDate
r58757* (bug 20112) Bitrotted tests in the t/ directory were failing. Patch by Dan ...avar11:06, 8 November 2009
r58762* (bug 20112) Bitrotted tests in the t/ directory were failing.avar12:47, 8 November 2009
r58767Rm TODOs introduced in r58756, Avar had a bug with SVN updates, causing this ...maxsem14:19, 8 November 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58548(bug 18609) Search index was empty for some pagesmaxsem15:18, 4 November 2009

Comments

#Comment by MaxSem (talk | contribs)   12:59, 8 November 2009

Avar, it seems after your complaints on IRC, that your version of includes/ is out of date.

#Comment by MaxSem (talk | contribs)   14:20, 8 November 2009

Reverted (though kept ok() --> isnt() conversion) per IRC discussion

Status & tagging log