r58752 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58751‎ | r58752 | r58753 >
Date:10:14, 8 November 2009
Author:btongminh
Status:ok
Tags:
Comment:
Properly normalize spaces of page titles.
Modified paths:
  • /trunk/extensions/GlobalUsage/GlobalUsage_body.php (modified) (history)
  • /trunk/extensions/GlobalUsage/SpecialGlobalUsage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalUsage/GlobalUsage_body.php
@@ -28,7 +28,7 @@
2929 'gil_wiki' => $this->interwiki,
3030 'gil_page' => $title->getArticleID( $pageIdFlags ),
3131 'gil_page_namespace' => $title->getNsText(),
32 - 'gil_page_title' => $title->getText(),
 32+ 'gil_page_title' => $title->getDBkey(),
3333 'gil_to' => $name
3434 );
3535 }
Index: trunk/extensions/GlobalUsage/SpecialGlobalUsage.php
@@ -109,7 +109,8 @@
110110
111111 $wiki = WikiMap::getWiki( $item['wiki'] );
112112
113 - return WikiMap::makeForeignLink( $item['wiki'], $page );
 113+ return WikiMap::makeForeignLink( $item['wiki'],
 114+ str_replace( '_', ' ', $page ) );
114115 }
115116
116117 public static function onImagePageAfterImageLinks( $imagePage, &$html ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r58753Merge r58752werdna10:17, 8 November 2009

Status & tagging log