r58695 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58694‎ | r58695 | r58696 >
Date:10:04, 7 November 2009
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
i18n for special page name
Modified paths:
  • /trunk/extensions/GlobalUsage/GlobalUsage.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalUsage/GlobalUsage.i18n.php
@@ -18,7 +18,7 @@
1919 'globalusage-text' => 'Search global file usage',
2020 'globalusage-on-wiki' => 'Usage of [[:File:$1|$1]] on $2',
2121 'globalusage-of-file' => 'The following other wikis use this image:',
22 - 'globalusage-more' => 'View [[Special:GlobalUsage/$1|more global usage]] of this file.',
 22+ 'globalusage-more' => 'View [[{{#Special:GlobalUsage}}/$1|more global usage]] of this file.',
2323 'globalusage-filterlocal' => 'Do not show local usage',
2424 );
2525

Comments

#Comment by Nikerabbit (talk | contribs)   14:07, 7 November 2009

If this actually changes something, I think there is a bug.

#Comment by Siebrand (talk | contribs)   15:27, 7 November 2009

The current parser does no i18n for special page URLs that are suffixed with a parameter. Using {{#special:pagename}} fixes that. This is also used in core in several places, and FlaggedRevs, IIRC. See example below.

'signature-anon' => '[[{{#special:Contributions}}/$1|$2]]',
#Comment by Umherirrender (talk | contribs)   19:42, 9 November 2009

But works fine for MediaWiki:Morelinkstoimage

Status & tagging log