r58597 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58596‎ | r58597 | r58598 >
Date:18:49, 5 November 2009
Author:freakolowsky
Status:ok
Tags:
Comment:
removed x-codeBlob functions and modified blob handling acordingly
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -276,9 +276,9 @@
277277
278278 function doQuery($sql) {
279279 wfDebug("SQL: [$sql]\n");
280 - if (!mb_check_encoding($sql)) {
281 - throw new MWException("SQL encoding is invalid");
282 - }
 280+// if (!mb_check_encoding($sql)) {
 281+// throw new MWException("SQL encoding is invalid\n$sql");
 282+// }
283283
284284 //handle some oracle specifics
285285 //remove AS column/table/subquery namings
@@ -478,8 +478,8 @@
479479 throw new DBUnexpectedError($this, "Cannot create LOB descriptor: " . $e['message']);
480480 }
481481
482 - if (is_object($val)) {
483 - $lob[$col]->writeTemporary($val->getData());
 482+ if ($col_type == 'BLOB') { //is_object($val)) {
 483+ $lob[$col]->writeTemporary($val); //->getData());
484484 oci_bind_by_name($stmt, ":$col", $lob[$col], -1, SQLT_BLOB);
485485 } else {
486486 $lob[$col]->writeTemporary($val);
@@ -952,13 +952,14 @@
953953 return str_replace("'", "''", $s);
954954 }
955955
 956+/*
956957 function encodeBlob($b) {
957 - return new ORABlob($b);
 958+ return $b; //new ORABlob($b);
958959 }
959960 function decodeBlob($b) {
960961 return $b; //return $b->load();
961962 }
962 -
 963+*/
963964 function addQuotes( $s ) {
964965 global $wgLang;
965966 if (isset($wgLang->mLoaded) && $wgLang->mLoaded)

Follow-up revisions

RevisionCommit summaryAuthorDate
r60914Remove code commented out by r58597tstarling00:55, 11 January 2010

Status & tagging log