r58595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58594‎ | r58595 | r58596 >
Date:18:41, 5 November 2009
Author:maxsem
Status:ok
Tags:
Comment:
implicitOrderby() seems to be true for SQLite, removing the override
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -32,10 +32,9 @@
3333 }
3434
3535 /**
36 - * todo: check if these should be true like parent class
 36+ * @todo: check if it should be true like parent class
3737 */
3838 function implicitGroupby() { return false; }
39 - function implicitOrderby() { return false; }
4039
4140 static function newFromParams( $server, $user, $password, $dbName, $failFunction = false, $flags = 0 ) {
4241 return new DatabaseSqlite( $server, $user, $password, $dbName, $failFunction, $flags );

Status & tagging log