r58594 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r58593‎ | r58594 | r58595 >
Date:18:40, 5 November 2009
Author:tparscal
Status:deferred
Tags:
Comment:
Commented out some code that was causing errors (need to solve it properly soon).
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.code.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js
@@ -101,6 +101,7 @@
102102 };
103103
104104 $.wikiEditor.fixOperaBrokenness = function( s ) {
 105+ /*
105106 // This function works around Opera's
106107 // broken newline handling in textareas.
107108 // .val() has \n while selection functions
@@ -113,11 +114,10 @@
114115 .height( 0 )
115116 .width( 0 )
116117 .insertBefore( $.wikiEditor.instances[0] );
117 - var textarea = $( '<textarea />' )
 118+ var textarea = $( '<textarea></textarea>' )
118119 .height( 0 )
119120 .appendTo( div )
120121 .val( "foo\r\nbar" );
121 -
122122 // Try to search&replace bar --> BAR
123123 var index = textarea.val().indexOf( 'bar' );
124124 textarea.select();
@@ -131,6 +131,7 @@
132132 }
133133 if ( $.isOperaBroken )
134134 s = s.replace( /\n/g, "\r\n" );
 135+ */
135136 return s;
136137 };
137138
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.code.js
@@ -112,9 +112,6 @@
113113 return context.modules.code.editor.active;
114114 }
115115 }
116 - getCaretPosition: function( context ) {
117 -
118 - }
119116 }
120117
121118 }; } ) ( jQuery );

Status & tagging log