r58429 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58428‎ | r58429 | r58430 >
Date:17:12, 2 November 2009
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Partly revert r57148. The search&replace was a bit too wide. It catches a message key too. Instead of right keys only.
Needs syncing with WMF because it shows <deletedhistory> on the live site.
Modified paths:
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FileDeleteForm.php
——@@ -97,7 +97,7 @@
9898 if( $status->ok ) {
9999 // Need to do a log item
100100 $log = new LogPage( 'delete' );
101 - $logComment = wfMsgForContent( 'deletedhistory', $oldimage );
 101+ $logComment = wfMsgForContent( 'deletedrevision', $oldimage );
102102 if( trim( $reason ) != '' )
103103 $logComment .= ": {$reason}";
104104 $log->addEntry( 'delete', $title, $logComment );

Follow-up revisions

RevisionCommit summaryAuthorDate
r58439Merged r58429: message fixaaron19:28, 2 November 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57148* Renamed deletedcontent to deletedtext...aaron19:50, 30 September 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   19:25, 2 November 2009

The replacing itself was actually manual

Status & tagging log